Adjust GC related settings for tests #15632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhimondr
force-pushed
the
adjust-gc-settings-for-tests
branch
from
06bd876 to
1a6cc43
Compare
please include this in commit message and/or code comment |
findepi
reviewed
Jan 6, 2023
| @@ -92,6 +92,9 @@ | |||
| Force bigger region size in attempt to help G1 utilize heap fully. --> | |||
| <air.test.jvm.additional-arguments> | |||
| -XX:G1HeapRegionSize=32M | |||
| -XX:+UnlockDiagnosticVMOptions | |||
| -XX:GCLockerRetryAllocationCount=10 | |||
There was a problem hiding this comment.
It's 2 by default, I think 10 should be sufficient. Do you think it should be higher?
There was a problem hiding this comment.
oh, thought default is about 10. fine.
maybe add <!-- bump from default of 2 --> ?
| @@ -92,6 +92,9 @@ | |||
| Force bigger region size in attempt to help G1 utilize heap fully. --> | |||
| <air.test.jvm.additional-arguments> | |||
| -XX:G1HeapRegionSize=32M | |||
| -XX:+UnlockDiagnosticVMOptions | |||
There was a problem hiding this comment.
is it required to set XX:GCLockerRetryAllocationCount ?
There was a problem hiding this comment.
It's actually needed for both 😃
arhimondr
force-pushed
the
adjust-gc-settings-for-tests
branch
from
1a6cc43 to
7d057be
Compare
To exclude the possibility of GCLocker and PreventiveGC related issues
arhimondr
force-pushed
the
adjust-gc-settings-for-tests
branch
from
7d057be to
b7ca58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To exclude the possibility of GCLocker and PreventiveGC related issues
Additional context and related issues
#15293
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: