Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in TestHiveGlueMetastore #14799

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix NPE in TestHiveGlueMetastore #14799

merged 1 commit into from
Oct 28, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 27, 2022

Introduced in bba041c.

Thanks to @findinpath for noticing.

@findepi findepi requested review from ebyhr and findinpath October 27, 2022 12:29
@cla-bot cla-bot bot added the cla-signed label Oct 27, 2022
@findepi
Copy link
Member Author

findepi commented Oct 27, 2022

Introduced in bba041c.

#14742 was not run with secrets and broke a test that requires secrets to run.

This was referenced Oct 27, 2022
Closed
Closed
@findepi findepi requested a review from kokosing October 27, 2022 12:41
@hashhar
Copy link
Member

hashhar commented Oct 28, 2022

Failures seems to be flaky:

tests               | 2022-10-28 01:47:51 INFO: FAILURE     /    io.trino.tests.product.hive.TestHiveViews.testRunAsInvoker (Groups: hive_views) took 10.5 seconds
tests               | 2022-10-28 01:47:51 SEVERE: Failure cause:
tests               | io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: Error executing query: java.net.SocketTimeoutException: timeout
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:119)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.executeQuery(JdbcQueryExecutor.java:84)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$1.lambda$executeQuery$0(QueryExecutors.java:60)
tests               | 	at net.jodah.failsafe.Functions.lambda$get$0(Functions.java:48)
tests               | 	at net.jodah.failsafe.RetryPolicyExecutor.lambda$supply$0(RetryPolicyExecutor.java:62)
tests               | 	at net.jodah.failsafe.Execution.executeSync(Execution.java:129)
tests               | 	at net.jodah.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:376)
tests               | 	at net.jodah.failsafe.FailsafeExecutor.get(FailsafeExecutor.java:67)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$1.executeQuery(QueryExecutors.java:60)
tests               | 	at io.trino.tests.product.hive.AbstractTestHiveViews.testRunAsInvoker(AbstractTestHiveViews.java:709)
tests               | 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
tests               | 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
tests               | 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
tests               | 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
tests               | 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
tests               | 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
tests               | 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
tests               | 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
tests               | 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
tests               | 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
tests               | 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
tests               | 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
tests               | 	at java.base/java.lang.Thread.run(Thread.java:833)
tests               | Caused by: java.sql.SQLException: Error executing query: java.net.SocketTimeoutException: timeout
tests               | 	at io.trino.jdbc.TrinoStatement.internalExecute(TrinoStatement.java:287)
tests               | 	at io.trino.jdbc.TrinoStatement.execute(TrinoStatement.java:240)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.executeQueryNoParams(JdbcQueryExecutor.java:128)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:112)
tests               | 	... 22 more
tests               | 	Suppressed: java.lang.Exception: Query: DROP TABLE IF EXISTS run_as_invoker
tests               | 		at io.trino.tempto.query.JdbcQueryExecutor.executeQueryNoParams(JdbcQueryExecutor.java:136)
tests               | 		... 23 more
tests               | Caused by: java.io.UncheckedIOException: java.net.SocketTimeoutException: timeout
tests               | 	at io.trino.jdbc.$internal.client.JsonResponse.execute(JsonResponse.java:166)
tests               | 	at io.trino.jdbc.$internal.client.StatementClientV1.<init>(StatementClientV1.java:116)
tests               | 	at io.trino.jdbc.$internal.client.StatementClientFactory.newStatementClient(StatementClientFactory.java:24)
tests               | 	at io.trino.jdbc.TrinoConnection.startQuery(TrinoConnection.java:758)
tests               | 	at io.trino.jdbc.TrinoStatement.internalExecute(TrinoStatement.java:252)
tests               | 	... 25 more
tests               | Caused by: java.net.SocketTimeoutException: timeout
tests               | 	at io.trino.jdbc.$internal.okio.Okio$4.newTimeoutException(Okio.java:232)
tests               | 	at io.trino.jdbc.$internal.okio.AsyncTimeout.exit(AsyncTimeout.java:286)
tests               | 	at io.trino.jdbc.$internal.okio.AsyncTimeout$2.read(AsyncTimeout.java:241)
tests               | 	at io.trino.jdbc.$internal.okio.RealBufferedSource.indexOf(RealBufferedSource.java:358)
tests               | 	at io.trino.jdbc.$internal.okio.RealBufferedSource.readUtf8LineStrict(RealBufferedSource.java:230)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http1.Http1ExchangeCodec.readHeaderLine(Http1ExchangeCodec.java:242)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http1.Http1ExchangeCodec.readResponseHeaders(Http1ExchangeCodec.java:213)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.java:115)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.java:94)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:43)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:94)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:88)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
tests               | 	at io.trino.jdbc.$internal.client.OkHttpUtil.lambda$userAgent$0(OkHttpUtil.java:70)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
tests               | 	at io.trino.jdbc.$internal.okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
tests               | 	at io.trino.jdbc.$internal.okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:229)
tests               | 	at io.trino.jdbc.$internal.okhttp3.RealCall.execute(RealCall.java:81)
tests               | 	at io.trino.jdbc.$internal.client.JsonResponse.execute(JsonResponse.java:124)
tests               | 	... 29 more
tests               | Caused by: java.net.SocketTimeoutException: Read timed out
tests               | 	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
tests               | 	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)
tests               | 	at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:350)
tests               | 	at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:803)
tests               | 	at java.base/java.net.Socket$SocketInputStream.read(Socket.java:976)
tests               | 	at io.trino.jdbc.$internal.okio.Okio$2.read(Okio.java:140)
tests               | 	at io.trino.jdbc.$internal.okio.AsyncTimeout$2.read(AsyncTimeout.java:237)
tests               | 	... 53 more

@losipiuk losipiuk merged commit 8599d90 into trinodb:master Oct 28, 2022
@github-actions github-actions bot added this to the 402 milestone Oct 28, 2022
@colebow colebow mentioned this pull request Nov 1, 2022
Merged
@findepi findepi deleted the findepi/glue-test-npe branch November 3, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findinpath findinpath findinpath approved these changes

@hashhar hashhar hashhar approved these changes

@ebyhr ebyhr ebyhr approved these changes

@losipiuk losipiuk losipiuk approved these changes

@kokosing kokosing Awaiting requested review from kokosing

Assignees
No one assigned
Labels
cla-signed
Milestone
402
Development

Successfully merging this pull request may close these issues.
5 participants
@findepi @hashhar @losipiuk @ebyhr @findinpath