Replace ImmutableList.copyOf with unmodifiableList in TestHiveGlueMetastore #14793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value is nullable.
ebyhr
added
the
no-release-notes
kokosing
reviewed
Oct 27, 2022
| @@ -1453,7 +1454,7 @@ private static PartitionValues make(String... values) | |||
|
|
|||
| private PartitionValues(List<String> values) | |||
| { | |||
| this.values = ImmutableList.copyOf(requireNonNull(values, "values is null")); | |||
| this.values = unmodifiableList(requireNonNull(values, "values is null")); | |||
There was a problem hiding this comment.
The value is nullable.
How come? You have requireNonNull.
There was a problem hiding this comment.
I mean the element, not values itself.
There was a problem hiding this comment.
sorry, wasn't aware of this PR and posted #14799 as a streamlined verison of #14796 that @findinpath pinged me about
note that this change logically partially reverts bba041c -- the PartitionValues becomes mutable again.
You need a defensive copy of the constructor arg and wrapping with unmodifiableList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value is nullable.
Description
Fix failure https://github.com/trinodb/trino/actions/runs/3335081229/jobs/5518683874
Release notes
(x) This is not user-visible or docs only and no release notes are required.