-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower log level in Kafka product tests #14645
Conversation
edeff82
to
ba5d092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ba5d092
to
20a77cf
Compare
log4j.logger.{{logger}}={{loglevel}} | ||
{% endfor %} | ||
|
||
log4j.logger.kafka.server.KafkaServer=INFO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out the environment depends on a started (kafka.server.KafkaServer)
log message.
Line 97 in 756be87
.waitingForAll(forSelectedPorts(9092), forLogMessage(".*started \\(kafka.server.KafkaServer\\).*", 1)) |
20a77cf
to
1e0b94e
Compare
Two possible flakiness issues. Otherwise this is good to go. @lukasz-walkiewicz do we need another approval? |
testing/trino-product-tests/src/main/java/io/trino/tests/product/kafka/KafkaProductTest.java
Outdated
Show resolved
Hide resolved
2d64fce
to
c9cce87
Compare
The |
0d9c444
to
78fed64
Compare
Also discovered that |
|
9abab28
to
839f495
Compare
Dead lock should be fixed now. Also noticed noisy logging from
|
529fe43
to
3f261be
Compare
Hit flaky test in Pinot #14239 |
Thanks! |
Description
Lower log level in Kafka containers and test code used in Kafka product tests
Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: