Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky maven checks due to connection timeout #3049

Closed
ebyhr opened this issue Mar 10, 2020 · 6 comments · Fixed by #3104
Closed

Flaky maven checks due to connection timeout #3049

ebyhr opened this issue Mar 10, 2020 · 6 comments · Fixed by #3104
Assignees
Labels
bug Something isn't working maintenance Project maintenance task test

Comments

@ebyhr
Copy link
Member

ebyhr commented Mar 10, 2020

https://github.com/prestosql/presto/runs/494862433
https://github.com/prestosql/presto/runs/496219090
https://github.com/prestosql/presto/actions/runs/52467359

@ebyhr ebyhr added test maintenance Project maintenance task labels Mar 10, 2020
@findepi findepi added the bug Something isn't working label Mar 10, 2020
@findepi
Copy link
Member

findepi commented Mar 10, 2020

We probably need a kind of a retry. But we also need timeouts. At least once, i saw a build that failed after long time trying to download something, looking like dead connection instead of fail fast.

@findepi
Copy link
Member

findepi commented Mar 10, 2020

https://github.com/prestosql/presto/runs/498096192?check_suite_focus=true

2020-03-10T15:00:08.0248082Z [INFO] BUILD FAILURE
2020-03-10T15:00:08.0248737Z [INFO] ------------------------------------------------------------------------
2020-03-10T15:00:08.0249010Z [INFO] Total time:  20:41 min (Wall Clock)
2020-03-10T15:00:08.0265233Z [INFO] Finished at: 2020-03-10T15:00:08Z
2020-03-10T15:00:08.0269078Z [INFO] ------------------------------------------------------------------------
2020-03-10T15:00:08.0295390Z [ERROR] Failed to execute goal on project presto-elasticsearch: Could not resolve dependencies for project io.prestosql:presto-elasticsearch:presto-plugin:331-SNAPSHOT: Could not transfer artifact org.elasticsearch:securesm:jar:1.1 from/to central (https://repo.maven.apache.org/maven2): Connection timed out (Read failed) -> [Help 1]

@findepi
Copy link
Member

findepi commented Mar 10, 2020

@findepi
Copy link
Member

findepi commented Mar 13, 2020

@findepi
Copy link
Member

findepi commented Mar 14, 2020

Apparently maven checks with Java 11, 13 are much more prone to fail -- https://github.com/prestosql/presto/runs/508208632

@findepi
Copy link
Member

findepi commented Mar 14, 2020

For maven checks sake, I added retry some time ago (1c10cc1).
It's ineffective now, because retry has time limit of 10 minutes, and build fails after 20 (with sample timing out download taking ~15 minutes (980 seconds) to time out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Project maintenance task test
Development

Successfully merging a pull request may close this issue.

2 participants