Don't overwrite reader and writer versions during COMMENT and ADD COLUMN in Delta
#14612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homar
approved these changes
Oct 13, 2022
findepi
approved these changes
Oct 13, 2022
| @@ -263,4 +263,32 @@ public void testTrinoAlterTablePreservesTableMetadata() | |||
| onTrino().executeQuery("DROP TABLE delta.default." + tableName); | |||
| } | |||
| } | |||
|
|
|||
| @Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS}) | |||
| public void testTrinoAlterTablePreservesReaderAndWriterVersions() | |||
There was a problem hiding this comment.
are we good for inserts, checkpoints, etc.?
There was a problem hiding this comment.
Those operations look fine. Added some statements to this test.
|
Can we put the minWriterVersion and minReaderVersion in the DeltaLakeTableHandle? Either way, thanks for spotting this |
ebyhr
force-pushed
the
ebi/delta-reader-writer-versions
branch
from
72524e2 to
5ab5ab4
Compare
ebyhr
changed the title
COMMENT and ADD COLUMN in DeltaCOMMENT and ADD COLUMN in Delta
Actually, I considered this during fixing, but we avoid adding fields to DeltaLakeTableHandle as much as possible. Let me keep as-is because the affected operations are only |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14611
Non-technical explanation
Release notes
(x) Release notes are required, with the following suggested text: