-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase max writer version to 4 for delta lake #14573
Increase max writer version to 4 for delta lake #14573
Conversation
f6dd86b
to
863ed73
Compare
...c/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksInsertCompatibility.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksInsertCompatibility.java
Show resolved
Hide resolved
be43764
to
4ca39a2
Compare
Currently, the connector uses hard-coded reader & writer version when appending a protocol entry. If we changes metadata (e.g. |
Yes i saw that, great you noticed that and made a fix. But does that affect this pr ? I haven't noticed a failure but there is so much flakiness that I may have missed something |
#14612 is required as a preparatory commit, but there's no need to change this PR. I found the above issue when I was trying to add some tests based on this PR. |
914d469
to
e631917
Compare
Rebased on upstream to resolve conflicts. |
Merged, thanks! |
Description
As we have checks that blocks writing to tables with specific features like CDF and generated columns we can safely update accepted writer version to 4.
I also refactored a little TestDeltaLakeDatabricksInsertCompatibility class
Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: