Don't keep mutable config instance on a field #14475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
added
maintenance
ksobolew
approved these changes
Oct 5, 2022
| @@ -119,7 +119,9 @@ public DynamicFilterService(Metadata metadata, FunctionManager functionManager, | |||
| this.metadata = requireNonNull(metadata, "metadata is null"); | |||
| this.functionManager = requireNonNull(functionManager, "functionManager is null"); | |||
| this.typeOperators = requireNonNull(typeOperators, "typeOperators is null"); | |||
| this.dynamicFilterConfig = requireNonNull(dynamicFilterConfig, "dynamicFilterConfig is null"); | |||
| requireNonNull(dynamicFilterConfig, "dynamicFilterConfig is null"); | |||
There was a problem hiding this comment.
nit: requireNonNull is not needed in Java 15+ when we immediately dereference the variable, because the NPE message will be as good or better. @findepi removed such calls en masse recently.
| this.smallPartitionedMaxSizePerOperator = dynamicFilterConfig.getSmallPartitionedMaxSizePerOperator(); | ||
|
|
||
|
|
||
| this.largePartitionedMaxDistinctValuesPerDriver = dynamicFilterConfig.getLargePartitionedMaxDistinctValuesPerDriver(); |
There was a problem hiding this comment.
No. Thanks for catching that. Removed the empty lines.
ebyhr
force-pushed
the
ebi/config-instance
branch
from
a255ffb to
6baa316
Compare
|
CI hit #14487 |
findepi
approved these changes
Oct 6, 2022
| @@ -119,7 +119,9 @@ public DynamicFilterService(Metadata metadata, FunctionManager functionManager, | |||
| this.metadata = requireNonNull(metadata, "metadata is null"); | |||
| this.functionManager = requireNonNull(functionManager, "functionManager is null"); | |||
| this.typeOperators = requireNonNull(typeOperators, "typeOperators is null"); | |||
| this.dynamicFilterConfig = requireNonNull(dynamicFilterConfig, "dynamicFilterConfig is null"); | |||
| requireNonNull(dynamicFilterConfig, "dynamicFilterConfig is null"); | |||
| @@ -467,7 +481,23 @@ public LocalExecutionPlanner( | |||
| this.joinCompiler = requireNonNull(joinCompiler, "joinCompiler is null"); | |||
| this.operatorFactories = requireNonNull(operatorFactories, "operatorFactories is null"); | |||
| this.orderingCompiler = requireNonNull(orderingCompiler, "orderingCompiler is null"); | |||
| this.dynamicFilterConfig = requireNonNull(dynamicFilterConfig, "dynamicFilterConfig is null"); | |||
| requireNonNull(dynamicFilterConfig, "dynamicFilterConfig is null"); | |||
ebyhr
force-pushed
the
ebi/config-instance
branch
from
6baa316 to
21c6004
Compare
|
Compatibility failed due to lack of the latest docker image. https://trinodb.slack.com/archives/CFP480UKX/p1665108934638869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't keep mutable config instance on a field
Release notes
(x) This is not user-visible or docs only and no release notes are required.