Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose delta.default-reader-version and delta.default-writer-version delta lake configuration properties #16208

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

krvikash
Copy link
Contributor

@krvikash krvikash commented Feb 21, 2023

Description

Follow up of #16165 (comment)

Release notes

(X) Release notes are required, with the following suggested text:

# Delta Lake
* Support setting default reader and writer versions using the `delta.default-reader-version` and 
  `delta.default-writer-version` config properties. ({issue}`16208`)

@krvikash krvikash force-pushed the trino-16165-follow-up branch from d529cb8 to c12f3a6 Compare February 22, 2023 09:08
@krvikash
Copy link
Contributor Author

Thank @ebyhr for the review. Addressed comments.

@krvikash krvikash force-pushed the trino-16165-follow-up branch from c12f3a6 to b7205d8 Compare February 22, 2023 13:56
@krvikash krvikash force-pushed the trino-16165-follow-up branch from b7205d8 to 96a8a7a Compare February 22, 2023 22:54
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit granularity seems wrong. Adding config properties without actual usage doesn't make sense. I would recommend squashing three commits into one.

@krvikash krvikash force-pushed the trino-16165-follow-up branch from 96a8a7a to 9673253 Compare February 22, 2023 23:16
@ebyhr ebyhr self-requested a review February 22, 2023 23:25
@krvikash krvikash force-pushed the trino-16165-follow-up branch 2 times, most recently from 7b61cde to 8f3306a Compare February 23, 2023 11:58
@krvikash krvikash changed the title Expose delta.reader-version and delta.writer-version delta lake configuration properties Expose delta.default-reader-version and delta.default-writer-version delta lake configuration properties Feb 23, 2023
@krvikash krvikash force-pushed the trino-16165-follow-up branch from 8f3306a to 0326b9e Compare February 23, 2023 12:01
@ebyhr
Copy link
Member

ebyhr commented Feb 23, 2023

/test-with-secrets sha=0326b9e5680df72d04db320e6c223590d609c3cf

Copy link
Member

@alexjo2144 alexjo2144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks

@ebyhr ebyhr force-pushed the trino-16165-follow-up branch from 0326b9e to b62941f Compare February 24, 2023 00:08
@ebyhr ebyhr merged commit 5416843 into trinodb:master Feb 24, 2023
@ebyhr ebyhr mentioned this pull request Feb 24, 2023
@krvikash krvikash deleted the trino-16165-follow-up branch February 24, 2023 07:04
@github-actions github-actions bot added this to the 409 milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants