Fix reading from Delta in a transaction #11792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homar
approved these changes
Apr 5, 2022
| "test_tx_insert", | ||
| "(a bigint)")) { | ||
| String tableName = table.getName(); | ||
| inTransaction(session -> assertUpdate(session, "INSERT INTO " + tableName + " VALUES 42", 1)); |
There was a problem hiding this comment.
just to make sure, this would work without your change(removing that 'verify') right?
There was a problem hiding this comment.
for Detla, the test would break at the skipTestUnless(hasBehavior(SUPPORTS_MULTI_STATEMENT_WRITES)); because Delta doesn't support this. Only Hive does ATM, AFAIR.
Delta connector supports write in autocommit mode only, but it should allow multiple reads in a transaction (e.g. reading from Delta and writing to Hive connector). The commit removes the check from `DeltaLakeConnector` since appropriate check is being done in `InMemoryTransactionManager`.
findepi
force-pushed
the
findepi/test-tx-ops
branch
from
b97012b to
b6f35af
Compare
homar
approved these changes
Apr 5, 2022
alexjo2144
reviewed
Apr 5, 2022
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConnector.java
Show resolved
Hide resolved
|
CI #10932 |
alexjo2144
approved these changes
Apr 5, 2022
losipiuk
approved these changes
Apr 6, 2022
|
CI #11825 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delta connector supports write in autocommit mode only, but it should
allow multiple reads in a transaction (e.g. reading from Delta and
writing to Hive connector).