Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong number of rows inserted into Hive with fault-tolerant execution #11825

Closed
findepi opened this issue Apr 6, 2022 · 6 comments
Closed

Wrong number of rows inserted into Hive with fault-tolerant execution #11825

findepi opened this issue Apr 6, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@findepi
Copy link
Member

findepi commented Apr 6, 2022

TestHiveFaultTolerantExecutionConnectorTest.testPartitionPerScanLimitWithMultiplePartitionColumns is flaky

Error:  io.trino.plugin.hive.TestHiveFaultTolerantExecutionConnectorTest.testPartitionPerScanLimitWithMultiplePartitionColumns  Time elapsed: 16.795 s  <<< FAILURE!
java.lang.AssertionError: 
[Rows for query [SELECT count(*) FROM test_multi_partition_per_scan_limit WHERE part1 IS NULL AND part2 < 1001]] 
Expecting:
  <(992)>
to contain exactly in any order:
  <[(1000)]>
elements not found:
  <(1000)>
and elements not expected:
  <(992)>

	at io.trino.sql.query.QueryAssertions$QueryAssert.lambda$matches$2(QueryAssertions.java:346)
	at io.trino.sql.query.QueryAssertions$QueryAssert.matches(QueryAssertions.java:333)
	at io.trino.sql.query.QueryAssertions$QueryAssert.matches(QueryAssertions.java:328)
	at io.trino.plugin.hive.BaseHiveConnectorTest.testPartitionPerScanLimitWithMultiplePartitionColumns(BaseHiveConnectorTest.java:3191)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

-- looks like a wrong number of rows got inserted

cc @arhimondr @losipiuk @linzebing

@findepi findepi added the bug Something isn't working label Apr 6, 2022
@arhimondr arhimondr self-assigned this Apr 6, 2022
@arhimondr
Copy link
Contributor

Looking

@arhimondr
Copy link
Contributor

#11870

@sopel39
Copy link
Member

sopel39 commented Apr 11, 2022

@arhimondr
Copy link
Contributor

Thanks @sopel39 . Seems like there's a one more problem. Will take a look

@arhimondr arhimondr reopened this Apr 11, 2022
@ebyhr
Copy link
Member

ebyhr commented Apr 14, 2022

testPartitionPerScanLimit also failed in https://github.com/trinodb/trino/runs/6016481992

@arhimondr
Copy link
Contributor

Fixed by #12248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants