Fix duplicate dereference pushdown in Iceberg and Hive #11567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2022
findepi
requested review from
hashhar,
martint,
wendigo,
phd3,
losipiuk and
alexjo2144
losipiuk
approved these changes
Mar 18, 2022
wendigo
approved these changes
Mar 18, 2022
- use `TrinoException` with `NOT_SUPPORTED` - use clear message
A regression test for row (struct) dereference pushdown within complex expressions where a field is dereferenced twice.
Before the change, projection pushdown with a column being referenced more than once could lead e.g. to an expression being returned from the connector, which did have an unbound variable.
findepi
force-pushed
the
findepi/fix-duplicate-dereference-pushdown
branch
from
63d0e14 to
1651fdf
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, projection pushdown with a column being referenced
more than once could lead e.g. to an expression being returned from the
connector, which did have an unbound variable.
Fixes #11559
Fixes #11560