Translate CAST to connector expression #11551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@findepi PTAL |
wendigo
force-pushed
the
serafin/translate-cast-only
branch
from
8a26e3a to
4895ebd
Compare
|
Rebased to include #11567 |
|
CI failure looks related. |
wendigo
force-pushed
the
serafin/translate-cast-only
branch
from
4895ebd to
9b52315
Compare
|
@findepi fixed |
wendigo
force-pushed
the
serafin/translate-cast-only
branch
from
9b52315 to
d8943b3
Compare
|
CI: #11275 |
|
CAST has the property that the target type is known, so it probably shouldn't be I think we should model the CAST as a |
wendigo
force-pushed
the
serafin/translate-cast-only
branch
from
d8943b3 to
5663f25
Compare
|
@findepi ptal |
|
I discussed this with @martint yesterday, and the conclusion was to model the CAST as a 1-arg The concerns were that it would prevent type inference if it is needed in the future, but we believe it won't be needed nor desired anyway. Also, our ConnectorExpression "language" doesn't have implicit coercions, and we don't want to change this. |
findepi
reviewed
Mar 31, 2022
core/trino-spi/src/main/java/io/trino/spi/expression/StandardFunctions.java
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/TestTableScanRedirectionWithPushdown.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/TestConnectorExpressionTranslator.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/TestConnectorExpressionTranslator.java
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/translate-cast-only
branch
2 times, most recently
from
4d028ea to
150c3d0
Compare
findepi
force-pushed
the
serafin/translate-cast-only
branch
from
150c3d0 to
2b5c7a5
Compare
findepi
approved these changes
Apr 7, 2022
core/trino-main/src/main/java/io/trino/sql/planner/ConnectorExpressionTranslator.java
Show resolved
Hide resolved
Co-authored-by: Raunaq Morarka <[email protected]>
findepi
force-pushed
the
serafin/translate-cast-only
branch
from
2b5c7a5 to
71d3fa9
Compare
|
there are some failures |
|
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted first commit from #11522