Enable TestAltinityConnectorSmokeTest in ClickHouse connector
#11095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/clickhouse-altinity-test
branch
2 times, most recently
from
7f0b570 to
a5f40e0
Compare
|
50 stress tests succeeded https://github.com/trinodb/trino/runs/5242608573 |
ebyhr
force-pushed
the
ebi/clickhouse-altinity-test
branch
from
a5f40e0 to
bb8602a
Compare
hashhar
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
This works because we updated version of Altinity we test against and we can now use newer driver with it which doesn't cause flakiness?
If my understanding is correct can you please add this to the commit message. It'll not be obvious why or how this got fixed in future.
The server version it was upgraded in 0196018 doesn't cause flaky issues with new driver package.
ebyhr
force-pushed
the
ebi/clickhouse-altinity-test
branch
from
bb8602a to
ad7d009
Compare
Right, updated the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable
TestAltinityConnectorSmokeTestin ClickHouse connectorRelated issues, pull requests, and links
n/a
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.