Skip to content

Commit

Permalink
Enable TestAltinityConnectorSmokeTest in ClickHouse connector
Browse files Browse the repository at this point in the history
The server version it was upgraded in 0196018
doesn't cause flaky issues with new driver package.
  • Loading branch information
ebyhr committed Feb 18, 2022
1 parent 698ff6c commit 3177d31
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 25 deletions.
23 changes: 0 additions & 23 deletions plugin/trino-clickhouse/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -180,27 +180,4 @@
<scope>test</scope>
</dependency>
</dependencies>

<profiles>
<profile>
<id>default</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes>
<!-- TODO (https://github.com/trinodb/trino/issues/10752) Enable after resolving flaky test issues -->
<exclude>**/TestAltinityConnectorSmokeTest.java</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ protected QueryRunner createQueryRunner()
ImmutableMap.of(),
ImmutableMap.<String, String>builder()
.put("clickhouse.map-string-as-varchar", "true") // To handle string types in TPCH tables as varchar instead of varbinary
.put("clickhouse.legacy-driver", "true")
.buildOrThrow(),
REQUIRED_TPCH_TABLES);
}
Expand All @@ -42,6 +41,6 @@ public void testRenameSchema()
{
// Override because RENAME DATABASE statement isn't supported in Altinity 20.8
assertThatThrownBy(super::testRenameSchema)
.hasMessageMatching("ClickHouse exception, code: 48,.* RENAME DATABASE is not supported.*\\n");
.hasMessageContaining("RENAME DATABASE is not supported");
}
}

0 comments on commit 3177d31

Please sign in to comment.