Commits on Feb 9, 2022

1. Do not interrupt threads other than TaskRunner on Driver#close …

   Driver methods such as Driver#updateSplitAssignment can be ran from a
   thread other than a thread created by TaskExecutor. Interrupting a
   thread that is not managed by the engine is potentially unsafe.
   
   For example the Jetty server may preserve the "interrupted" flag in between
   requests, potentially impacting a different task or a query:
   jetty/jetty.project#7548
   
   While the issue in Jetty is likely a bug that will be fixed there is no
   real reason why to interrupt a method other than Driver#process (which
   is only invoked by the TaskExecutor).
   
   Other driver methods (such as Driver#updateSplitAssignment) are
   lightweight and shouldn't take any significant time to finish while the
   interrupt mechanism is rather intended to terminate a processing
   that could potentially take a significant amount of time.

   

   arhimondr committed Feb 9, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 5ded6b1
   • Browse repository at this point

   Copy the full SHA

   5ded6b1 View commit details

   Browse the repository at this point in the history