Avoid interrupting jetty threads #10987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhimondr
force-pushed
the
avoid-interrupting-jetty-threads
branch
from
f87eead
to
507e200
Compare
linzebing
approved these changes
Feb 9, 2022
|
Nit: |
findepi
reviewed
Feb 9, 2022
losipiuk
approved these changes
Feb 9, 2022
Driver methods such as Driver#updateSplitAssignment can be ran from a thread other than a thread created by TaskExecutor. Interrupting a thread that is not managed by the engine is potentially unsafe. For example the Jetty server may preserve the "interrupted" flag in between requests, potentially impacting a different task or a query: jetty/jetty.project#7548 While the issue in Jetty is likely a bug that will be fixed there is no real reason why to interrupt a method other than Driver#process (which is only invoked by the TaskExecutor). Other driver methods (such as Driver#updateSplitAssignment) are lightweight and shouldn't take any significant time to finish while the interrupt mechanism is rather intended to terminate a processing that could potentially take a significant amount of time.
arhimondr
force-pushed
the
avoid-interrupting-jetty-threads
branch
from
507e200
to
5ded6b1
Compare
|
@dain PTAL - it is your area. |
sopel39
approved these changes
Feb 11, 2022
| } | ||
|
|
||
| // Note: task cannot return null | ||
| private <T> Optional<T> tryWithLock(long timeout, TimeUnit unit, Supplier<T> task) |
There was a problem hiding this comment.
nit: keep this method maybe so that you don't have to add true argument for existing tryWithLock invodations
There was a problem hiding this comment.
Since this is a private method I wasn't sure if it is worth adding extra overloads (as then you have to document them as well :-))
Testing interrupt is usually painful. I don't think we have a test for the existing interruption logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Driver methods such as Driver#updateSplitAssignment can be ran from a
thread other than a thread created by TaskExecutor. Interrupting a
thread that is not managed by the engine is potentially unsafe.
For example the Jetty server may preserve the "interrupted" flag in between
requests, potentially impacting a different task or a query:
jetty/jetty.project#7548
While the issue in Jetty is likely a bug that will be fixed there is no
real reason why to interrupt a method other than Driver#process (which
is only invoked by the TaskExecutor).
Other driver methods (such as Driver#updateSplitAssignment) are
lightweight and shouldn't take any significant time to finish while the
interrupt mechanism is rather intended to terminate a processing
that could potentially take a significant amount of time.
General information
Fixes #10773
Direct link to a comment describing the problem: #10773 (comment)
Related issues, pull requests, and links
jetty/jetty.project#7548
Documentation
No documentation is needed.
Release notes
No release notes entries required.