Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create plan for Kinesis connector changes #23921

Open
mosabua opened this issue Oct 25, 2024 · 4 comments
Open

Create plan for Kinesis connector changes #23921

mosabua opened this issue Oct 25, 2024 · 4 comments
Assignees
@mosabua
Labels
roadmap Top level issues for major efforts in the project

Comments

@mosabua
Copy link
Member

mosabua commented Oct 25, 2024 •
edited
Loading

The Kinesis connector seems to have very limited usage from looking at slack conversations and vendor data.

The current connector codebase uses a old, deprecated SDK for Kinesis that is now in maintenance mode and will be completely deprecated in 2025. Nobody is available to improve the connector and upgrade it to the newer SDK.

This issue was raised in a maintainer call on the 24th of October 2024 by @wendigo and discussed with all the present maintainers.

We are contemplating removal of the connector similar to #23792 .

We are currently looking for more input and data about potential usage. Please comment in this ticket if you are using the Kinesis connector.

More importantly we are also looking for contributors who are willing to update the connector to the new SDK.
@mosabua mosabua added the roadmap Top level issues for major efforts in the project label Oct 25, 2024
@mosabua mosabua self-assigned this Oct 25, 2024
@raunaqmorarka
Copy link
Member

That connector was contributed to Trino by one of my colleagues at Qubole. We contributed it because we had no customers using it, didn't want to invest any more in maintaining it and thought that giving it to the community might breathe some life into it.
My impression is that it has stayed unused in Trino as well and it should be okay to remove it.

@mosabua mosabua mentioned this issue Oct 25, 2024
Draft
@mosabua
Copy link
Member Author

mosabua commented Oct 25, 2024

I prepared a PR in case we want to go ahead with removal - which seems likely at this stage.

@mosabua
Copy link
Member Author

mosabua commented Oct 29, 2024

I reached out to AWS team and Amazon Kinesis team .. hopefully we get some input from them.

mosabua added a commit to simpligility/trino that referenced this issue Oct 29, 2024
@mosabua
Remove the Kinesis connector
0a24649 
The connector seems unused from all interaction on the community
and following an investigation with users, vendors, and customers.

The SDK used is deprecated and will be removed.

More details about the removal are captured in
trinodb#23921
@mosabua
Copy link
Member Author

mosabua commented Dec 9, 2024

At this stage we will ask again at Trino Summit but will most likely remove the connector. No vendors chimed in with any interest either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mosabua mosabua

Labels
roadmap Top level issues for major efforts in the project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mosabua @raunaqmorarka