Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UserInfo serialization to handle absent values #464

Merged

Conversation

Chaho12
Copy link
Member

@Chaho12 Chaho12 commented Sep 6, 2024

Description

Improve UserInfo serialization to handle absent values.

Additional context and related issues

Serialization of UserInfo was added at this PR

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

As Manfred saids, this fixes feature within same release (11) so no need for release note

@Chaho12 Chaho12 added the bug Something isn't working label Sep 6, 2024
@cla-bot cla-bot bot added the cla-signed label Sep 6, 2024
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Release note should talk about fixing an issue and from the user perspective. But I also think this was a regression during the development since 10 so maybe we dont need a release notes entry at all.

Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosabua mosabua merged commit 23e8320 into trinodb:main Sep 9, 2024
3 checks passed
@github-actions github-actions bot added this to the 11 milestone Sep 9, 2024
@Chaho12 Chaho12 deleted the feature/jyoo/fix-userinfo-serialization branch September 10, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-signed
Development

Successfully merging this pull request may close these issues.

3 participants