Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm chart version to 10 #438

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

oneonestar
Copy link
Member

Description

Update Helm chart version to 10.
Related to #437.

version should follow semantic versioning (X.Y.Z).
I'm thinking about:

X follows trino-gateway release
Y for helm chart breaking updates
Z for minor bug fixes

wdyt @willmostly

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@oneonestar oneonestar requested a review from willmostly August 16, 2024 12:47
@cla-bot cla-bot bot added the cla-signed label Aug 16, 2024
@mosabua
Copy link
Member

mosabua commented Aug 20, 2024

Also note that 10 is a perfectly fine semantic version number as well

@oneonestar
Copy link
Member Author

Also note that 10 is a perfectly fine semantic version number as well

I don't think so.

https://helm.sh/docs/topics/charts/#charts-and-versioning

Every chart must have a version number. A version must follow the SemVer 2 standard.

https://semver.org/

<version core> ::= <major> "." <minor> "." <patch>

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets roll with this.

@mosabua mosabua merged commit aeb49b6 into trinodb:main Aug 21, 2024
2 checks passed
@github-actions github-actions bot added this to the 11 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants