Add JmxOpenMetricsModule #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you chime in here @mattstep ? Do we want to be able to enable/disable it or is this all built into the module and ready to go and we just got to update the docs? |
|
OpenMetrics is different from OpenTelemetry. |
willmostly
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Looks good. Should we add the configuration snippet example here?
oneonestar
force-pushed
the
star/JmxOpenMetrics
branch
from
628e0ec to
2b81d49
Compare
Ooops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add JmxOpenMetricsModule.
Release notes
(x) Release notes are required, with the following suggested text: