Fix fetching networks on contacts migration #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asiia-trilitech
force-pushed
the
fix-network-migration-in-address-book
branch
from
e635781 to
666878b
Compare
Coverage report
Test suite run success1376 tests passing in 172 suites. Report generated by 🧪jest coverage report action from f058324 |
asiia-trilitech
force-pushed
the
fix-network-migration-in-address-book
branch
from
666878b to
12876bd
Compare
serjonya-trili
approved these changes
Apr 16, 2024
asiia-trilitech
force-pushed
the
fix-network-migration-in-address-book
branch
from
12876bd to
f058324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Applying migration on an empty Address Book resulted in a huge list of empty contacts.
The cause was applying empty filter to the fetch request.
Types of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist