Merge pull request #1126 from trilitech/fix-network-migration-in-addr…

…ess-book

Fix fetching networks on contacts migration

src/utils/multisig/fetch.test.ts

@@ -76,6 +76,7 @@ describe("multisig fetch", () => {
               in: ["pkh1,pkh2,pkh3"],
             },
             select: { fields: ["address"] },
+            limit: 3,
           },
           { baseUrl: network.tzktApiUrl }
         );

src/utils/multisig/fetch.ts

@@ -35,6 +35,7 @@ export const getExistingContracts = (pkhs: RawPkh[], network: Network): Promise<
     {
       address: { in: [pkhs.join(",")] },
       select: { fields: ["address"] },
+      limit: Math.min(10000, pkhs.length),
     },
     {
       baseUrl: network.tzktApiUrl,

src/utils/multisig/helper.test.ts

@@ -118,6 +118,7 @@ describe("multisig helpers", () => {
             in: ["pkh1,pkh2,pkh3"],
           },
           select: { fields: ["address"] },
+          limit: 3,
         },
         { baseUrl: MAINNET.tzktApiUrl }
       );
@@ -127,6 +128,7 @@ describe("multisig helpers", () => {
             in: ["pkh1,pkh2,pkh3"],
           },
           select: { fields: ["address"] },
+          limit: 3,
         },
         { baseUrl: GHOSTNET.tzktApiUrl }
       );
@@ -151,5 +153,19 @@ describe("multisig helpers", () => {
         ])
       );
     });
+
+    it("returns empty map for empty contracts list", async () => {
+      mockedContractsGet.mockImplementation((...args) => {
+        if (args[1].baseUrl === MAINNET.tzktApiUrl) {
+          return Promise.resolve(["pkh1", "pkh3", "pkh4"] as any);
+        } else {
+          return Promise.resolve(["pkh2", "pkh5"] as any);
+        }
+      });
+
+      const result = await getNetworksForContracts([MAINNET, GHOSTNET], []);
+
+      expect(result).toEqual(new Map());
+    });
   });
 });

src/utils/multisig/helpers.ts

@@ -49,6 +49,10 @@ export const getNetworksForContracts = async (
 ): Promise<Map<RawPkh, string>> => {
   const result = new Map<RawPkh, string>();
 
+  if (contractPkhs.length === 0) {
+    return result;
+  }
+
   const accountsWithNetwork = await Promise.all(
     availableNetworks.map(async network =>
       (await getExistingContracts(contractPkhs, network)).map(contractPkh => [
@@ -58,7 +62,6 @@ export const getNetworksForContracts = async (
     )
   );
   accountsWithNetwork.flat().forEach(([pkh, network]) => result.set(pkh, network));
-
   return result;
 };
 

src/utils/redux/migrations.ts

@@ -84,4 +84,5 @@ export const accountsMigrations = {
       });
     }),
   5: identity,
+  6: identity,
 } as any;