Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PB layout for Review operation #138

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Use PB layout for Review operation #138

merged 1 commit into from
Nov 23, 2023

Conversation

ajinkyaraj-23
Copy link
Collaborator

Assign PB layout for Review Operation screen.

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@Change-Layout-for-Review-Operation branch from a5f3811 to 40a8e36 Compare November 21, 2023 11:25
@spalmer25 spalmer25 mentioned this pull request Nov 21, 2023
Merged
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@Change-Layout-for-Review-Operation branch 3 times, most recently from 1bd2835 to 2971b10 Compare November 22, 2023 15:15
@spalmer25 spalmer25 self-requested a review November 22, 2023 15:48
spalmer25
spalmer25 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Nov 22, 2023
@emturner emturner added app::wallet issues relating to the wallet app device::NANOS Issues affecting NANOS device device::NANOX Issues affecting NANOX device device::NANOSP Issues affecting NANOSP device labels Nov 23, 2023
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@Change-Layout-for-Review-Operation branch 2 times, most recently from 18de8a6 to c3100d1 Compare November 23, 2023 15:32
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@Change-Layout-for-Review-Operation branch from c3100d1 to 639d57a Compare November 23, 2023 15:57
@ajinkyaraj-23 ajinkyaraj-23 merged commit 69515e4 into main Nov 23, 2023
50 checks passed
@emturner emturner deleted the ajinkyaraj-23@Change-Layout-for-Review-Operation branch November 23, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmer25 spalmer25 spalmer25 approved these changes

@emturner emturner emturner approved these changes

Assignees

@ajinkyaraj-23 ajinkyaraj-23

Labels
app::wallet issues relating to the wallet app device::NANOS Issues affecting NANOS device device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device
Projects
None yet
Milestone
Wallet: v3.0.0 - ledger feeback
Development

Successfully merging this pull request may close these issues.
3 participants
@ajinkyaraj-23 @emturner @spalmer25