Merge pull request #138 from trilitech/ajinkyaraj-23@Change-Layout-fo…

…r-Review-Operation Use PB layout for Review operation
trilitech · Nov 23, 2023 · 69515e4 · 69515e4
2 parents 4fd2769 + 639d57a
commit 69515e4
Show file tree

Hide file tree

Showing 117 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/swap.yml b/.github/workflows/swap.yml
@@ -12,7 +12,7 @@ jobs:
     uses: functori/app-exchange/.github/workflows/reusable_swap_functional_tests.yml@eaa2ad414d01e56389fa3214917cd15c12c5b2f9
     with:
       repo_for_exchange: 'functori/app-exchange'
-      branch_for_exchange: 'eaa2ad414d01e56389fa3214917cd15c12c5b2f9'
+      branch_for_exchange: '20a54e4b4b0afa30592e3bbedd44ebd1da002e68'
       branch_for_tezos: ${{ github.ref }}
       run_for_devices: '["nanos", "nanosp"]'
       test_filter: '"tezos_new"'
diff --git a/app/src/apdu_sign.c b/app/src/apdu_sign.c
@@ -430,10 +430,10 @@ handle_first_apdu_clear(__attribute__((unused)) command_t *cmd)
 
 #ifdef TARGET_NANOS
     tz_ui_stream_push(TZ_UI_STREAM_CB_NOCB, "Review operation", "",
-                      TZ_UI_LAYOUT_BP, TZ_UI_ICON_EYE);
+                      TZ_UI_LAYOUT_HOME_PB, TZ_UI_ICON_EYE);
 #elif defined(HAVE_BAGL)
     tz_ui_stream_push(TZ_UI_STREAM_CB_NOCB, "Review", "operation",
-                      TZ_UI_LAYOUT_BP, TZ_UI_ICON_EYE);
+                      TZ_UI_LAYOUT_HOME_PB, TZ_UI_ICON_EYE);
 #endif
 
     tz_operation_parser_init(st, TZ_UNKNOWN_SIZE, false);

diff --git a/tests/integration/nano/snapshots/nanos/regression_batched_ops/00000.png b/tests/integration/nano/snapshots/nanos/regression_batched_ops/00000.png
diff --git a/...on/nano/snapshots/nanos/test_blindsign_reject/reject_from_blind/clear/00000.png b/...on/nano/snapshots/nanos/test_blindsign_reject/reject_from_blind/clear/00000.png
diff --git a/...egration/nano/snapshots/nanos/test_blindsign_reject/reject_from_clear/00000.png b/...egration/nano/snapshots/nanos/test_blindsign_reject/reject_from_clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_blindsign_too_deep/clear/00000.png b/tests/integration/nano/snapshots/nanos/test_blindsign_too_deep/clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_blindsign_too_large/clear/00000.png b/tests/integration/nano/snapshots/nanos/test_blindsign_too_large/clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_ensure_always_clearsign/00000.png b/tests/integration/nano/snapshots/nanos/test_ensure_always_clearsign/00000.png
diff --git a/...on/nano/snapshots/nanos/test_parsing_errors/one_byte_added_at_the_end/00000.png b/...on/nano/snapshots/nanos/test_parsing_errors/one_byte_added_at_the_end/00000.png
diff --git a/...ration/nano/snapshots/nanos/test_parsing_errors/one_byte_added_inside/00000.png b/...ration/nano/snapshots/nanos/test_parsing_errors/one_byte_added_inside/00000.png
diff --git a/...tion/nano/snapshots/nanos/test_parsing_errors/one_byte_removed_inside/00000.png b/...tion/nano/snapshots/nanos/test_parsing_errors/one_byte_removed_inside/00000.png
diff --git a/...egration/nano/snapshots/nanos/test_parsing_errors/unknown_magic_bytes/00000.png b/...egration/nano/snapshots/nanos/test_parsing_errors/unknown_magic_bytes/00000.png
diff --git a/...ntegration/nano/snapshots/nanos/test_parsing_errors/unknown_operation/00000.png b/...ntegration/nano/snapshots/nanos/test_parsing_errors/unknown_operation/00000.png
diff --git a/...ntegration/nano/snapshots/nanos/test_parsing_errors/wrong_last_packet/00000.png b/...ntegration/nano/snapshots/nanos/test_parsing_errors/wrong_last_packet/00000.png
diff --git a/.../snapshots/nanos/test_regression_continue_after_reject/reject_signing/00000.png b/.../snapshots/nanos/test_regression_continue_after_reject/reject_signing/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_reject_transaction/00000.png b/tests/integration/nano/snapshots/nanos/test_reject_transaction/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_ballot/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_ballot/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_delegation/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_delegation/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_failing_noop/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_failing_noop/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_increase_paid_storage/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_increase_paid_storage/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_micheline_without_hash/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_micheline_without_hash/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_origination/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_origination/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_proposals/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_proposals/00000.png
diff --git a/...s/integration/nano/snapshots/nanos/test_sign_register_global_constant/00000.png b/...s/integration/nano/snapshots/nanos/test_sign_register_global_constant/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_reveal/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_reveal/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_sc_rollup_add_messages/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_sc_rollup_add_messages/00000.png
diff --git a/...ation/nano/snapshots/nanos/test_sign_sc_rollup_execute_outbox_message/00000.png b/...ation/nano/snapshots/nanos/test_sign_sc_rollup_execute_outbox_message/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_sc_rollup_originate/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_sc_rollup_originate/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_set_consensus_key/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_set_consensus_key/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_set_deposit_limit/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_set_deposit_limit/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_transaction/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_transaction/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_transfer_ticket/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_transfer_ticket/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_with_another_seed/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_with_another_seed/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_sign_with_long_hash/00000.png b/tests/integration/nano/snapshots/nanos/test_sign_with_long_hash/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_too_deep/00000.png b/tests/integration/nano/snapshots/nanos/test_too_deep/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_too_large/00000.png b/tests/integration/nano/snapshots/nanos/test_too_large/00000.png
diff --git a/...tegration/nano/snapshots/nanos/test_tz1_bip25519_sign_micheline_basic/00000.png b/...tegration/nano/snapshots/nanos/test_tz1_bip25519_sign_micheline_basic/00000.png
diff --git a/...ntegration/nano/snapshots/nanos/test_tz1_ed25519_sign_micheline_basic/00000.png b/...ntegration/nano/snapshots/nanos/test_tz1_ed25519_sign_micheline_basic/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_tz2_sign_micheline_basic/00000.png b/tests/integration/nano/snapshots/nanos/test_tz2_sign_micheline_basic/00000.png
diff --git a/tests/integration/nano/snapshots/nanos/test_tz3_sign_micheline_basic/00000.png b/tests/integration/nano/snapshots/nanos/test_tz3_sign_micheline_basic/00000.png
diff --git a/...s/integration/nano/snapshots/nanosp/regression_potential_empty_screen/00000.png b/...s/integration/nano/snapshots/nanosp/regression_potential_empty_screen/00000.png
diff --git a/...no/snapshots/nanosp/regression_press_right_works_across_apdu_recieves/00000.png b/...no/snapshots/nanosp/regression_press_right_works_across_apdu_recieves/00000.png
diff --git a/...n/nano/snapshots/nanosp/test_blindsign_reject/reject_from_blind/clear/00000.png b/...n/nano/snapshots/nanosp/test_blindsign_reject/reject_from_blind/clear/00000.png
diff --git a/...gration/nano/snapshots/nanosp/test_blindsign_reject/reject_from_clear/00000.png b/...gration/nano/snapshots/nanosp/test_blindsign_reject/reject_from_clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_blindsign_too_deep/clear/00000.png b/tests/integration/nano/snapshots/nanosp/test_blindsign_too_deep/clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_blindsign_too_large/clear/00000.png b/tests/integration/nano/snapshots/nanosp/test_blindsign_too_large/clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_ensure_always_clearsign/00000.png b/tests/integration/nano/snapshots/nanosp/test_ensure_always_clearsign/00000.png
diff --git a/...n/nano/snapshots/nanosp/test_parsing_errors/one_byte_added_at_the_end/00000.png b/...n/nano/snapshots/nanosp/test_parsing_errors/one_byte_added_at_the_end/00000.png
diff --git a/...ation/nano/snapshots/nanosp/test_parsing_errors/one_byte_added_inside/00000.png b/...ation/nano/snapshots/nanosp/test_parsing_errors/one_byte_added_inside/00000.png
diff --git a/...ion/nano/snapshots/nanosp/test_parsing_errors/one_byte_removed_inside/00000.png b/...ion/nano/snapshots/nanosp/test_parsing_errors/one_byte_removed_inside/00000.png
diff --git a/...gration/nano/snapshots/nanosp/test_parsing_errors/unknown_magic_bytes/00000.png b/...gration/nano/snapshots/nanosp/test_parsing_errors/unknown_magic_bytes/00000.png
diff --git a/...tegration/nano/snapshots/nanosp/test_parsing_errors/unknown_operation/00000.png b/...tegration/nano/snapshots/nanosp/test_parsing_errors/unknown_operation/00000.png
diff --git a/...tegration/nano/snapshots/nanosp/test_parsing_errors/wrong_last_packet/00000.png b/...tegration/nano/snapshots/nanosp/test_parsing_errors/wrong_last_packet/00000.png
diff --git a/...snapshots/nanosp/test_regression_continue_after_reject/reject_signing/00000.png b/...snapshots/nanosp/test_regression_continue_after_reject/reject_signing/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_reject_transaction/00000.png b/tests/integration/nano/snapshots/nanosp/test_reject_transaction/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_ballot/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_ballot/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_delegation/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_delegation/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_failing_noop/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_failing_noop/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_increase_paid_storage/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_increase_paid_storage/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_micheline_without_hash/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_micheline_without_hash/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_origination/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_origination/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_proposals/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_proposals/00000.png
diff --git a/.../integration/nano/snapshots/nanosp/test_sign_register_global_constant/00000.png b/.../integration/nano/snapshots/nanosp/test_sign_register_global_constant/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_reveal/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_reveal/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_sc_rollup_add_messages/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_sc_rollup_add_messages/00000.png
diff --git a/...tion/nano/snapshots/nanosp/test_sign_sc_rollup_execute_outbox_message/00000.png b/...tion/nano/snapshots/nanosp/test_sign_sc_rollup_execute_outbox_message/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_sc_rollup_originate/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_sc_rollup_originate/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_set_consensus_key/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_set_consensus_key/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_set_deposit_limit/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_set_deposit_limit/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_transaction/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_transaction/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_transfer_ticket/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_transfer_ticket/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_with_another_seed/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_with_another_seed/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_sign_with_long_hash/00000.png b/tests/integration/nano/snapshots/nanosp/test_sign_with_long_hash/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_too_deep/00000.png b/tests/integration/nano/snapshots/nanosp/test_too_deep/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_too_large/00000.png b/tests/integration/nano/snapshots/nanosp/test_too_large/00000.png
diff --git a/...egration/nano/snapshots/nanosp/test_tz1_bip25519_sign_micheline_basic/00000.png b/...egration/nano/snapshots/nanosp/test_tz1_bip25519_sign_micheline_basic/00000.png
diff --git a/...tegration/nano/snapshots/nanosp/test_tz1_ed25519_sign_micheline_basic/00000.png b/...tegration/nano/snapshots/nanosp/test_tz1_ed25519_sign_micheline_basic/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_tz2_sign_micheline_basic/00000.png b/tests/integration/nano/snapshots/nanosp/test_tz2_sign_micheline_basic/00000.png
diff --git a/tests/integration/nano/snapshots/nanosp/test_tz3_sign_micheline_basic/00000.png b/tests/integration/nano/snapshots/nanosp/test_tz3_sign_micheline_basic/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/regression_batched_ops/00000.png b/tests/integration/nano/snapshots/nanox/regression_batched_ops/00000.png
diff --git a/...on/nano/snapshots/nanox/test_blindsign_reject/reject_from_blind/clear/00000.png b/...on/nano/snapshots/nanox/test_blindsign_reject/reject_from_blind/clear/00000.png
diff --git a/...egration/nano/snapshots/nanox/test_blindsign_reject/reject_from_clear/00000.png b/...egration/nano/snapshots/nanox/test_blindsign_reject/reject_from_clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_blindsign_too_deep/clear/00000.png b/tests/integration/nano/snapshots/nanox/test_blindsign_too_deep/clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_blindsign_too_large/clear/00000.png b/tests/integration/nano/snapshots/nanox/test_blindsign_too_large/clear/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_ensure_always_clearsign/00000.png b/tests/integration/nano/snapshots/nanox/test_ensure_always_clearsign/00000.png
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00000.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00000.png
diff --git a/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00000.png b/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00000.png
diff --git a/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00000.png b/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00000.png
diff --git a/...egration/nano/snapshots/nanox/test_parsing_errors/unknown_magic_bytes/00000.png b/...egration/nano/snapshots/nanox/test_parsing_errors/unknown_magic_bytes/00000.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/unknown_operation/00000.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/unknown_operation/00000.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00000.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00000.png
diff --git a/.../snapshots/nanox/test_regression_continue_after_reject/reject_signing/00000.png b/.../snapshots/nanox/test_regression_continue_after_reject/reject_signing/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_reject_transaction/00000.png b/tests/integration/nano/snapshots/nanox/test_reject_transaction/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_ballot/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_ballot/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_delegation/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_delegation/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_failing_noop/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_failing_noop/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_increase_paid_storage/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_increase_paid_storage/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_micheline_without_hash/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_micheline_without_hash/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_origination/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_origination/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_proposals/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_proposals/00000.png
diff --git a/...s/integration/nano/snapshots/nanox/test_sign_register_global_constant/00000.png b/...s/integration/nano/snapshots/nanox/test_sign_register_global_constant/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_reveal/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_reveal/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_sc_rollup_add_messages/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_sc_rollup_add_messages/00000.png
diff --git a/...ation/nano/snapshots/nanox/test_sign_sc_rollup_execute_outbox_message/00000.png b/...ation/nano/snapshots/nanox/test_sign_sc_rollup_execute_outbox_message/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_sc_rollup_originate/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_sc_rollup_originate/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_set_consensus_key/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_set_consensus_key/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_set_deposit_limit/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_set_deposit_limit/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_transaction/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_transaction/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_transfer_ticket/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_transfer_ticket/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_with_another_seed/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_with_another_seed/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_sign_with_long_hash/00000.png b/tests/integration/nano/snapshots/nanox/test_sign_with_long_hash/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_too_deep/00000.png b/tests/integration/nano/snapshots/nanox/test_too_deep/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_too_large/00000.png b/tests/integration/nano/snapshots/nanox/test_too_large/00000.png
diff --git a/...tegration/nano/snapshots/nanox/test_tz1_bip25519_sign_micheline_basic/00000.png b/...tegration/nano/snapshots/nanox/test_tz1_bip25519_sign_micheline_basic/00000.png
diff --git a/...ntegration/nano/snapshots/nanox/test_tz1_ed25519_sign_micheline_basic/00000.png b/...ntegration/nano/snapshots/nanox/test_tz1_ed25519_sign_micheline_basic/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_tz2_sign_micheline_basic/00000.png b/tests/integration/nano/snapshots/nanox/test_tz2_sign_micheline_basic/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_tz3_sign_micheline_basic/00000.png b/tests/integration/nano/snapshots/nanox/test_tz3_sign_micheline_basic/00000.png