Skip to content

Add code quality checks #22

Add code quality checks

Add code quality checks #22

GitHub Actions / Results of CppCheck completed Feb 29, 2024 in 1s

Results of CppCheck

21 warning(s) found

Annotations

Check warning on line 31 in src/apdu_pubkey.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

Redundant code: Found a statement that begins with string constant.

Redundant code: Found a statement that begins with string constant.

Check warning on line 32 in src/apdu_pubkey.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

Redundant code: Found a statement that begins with string constant.

Redundant code: Found a statement that begins with string constant.

Check warning on line 68 in src/apdu_setup.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The address of local variable 'main' might be accessed at non-zero index.

The address of local variable 'main' might be accessed at non-zero index.

Check warning on line 71 in src/apdu_setup.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The address of local variable 'test' might be accessed at non-zero index.

The address of local variable 'test' might be accessed at non-zero index.

Check warning on line 171 in src/baking_auth.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

'data' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.

'data' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.

Check warning on line 185 in src/baking_auth.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

'fitness' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.

'fitness' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.

Check warning on line 185 in src/baking_auth.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

'data' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.

'data' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.

Check warning on line 189 in src/baking_auth.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

'fitness' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.

'fitness' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.

Check warning on line 189 in src/baking_auth.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

'fitness+fitness_size' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.

'fitness+fitness_size' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.

Check warning on line 108 in src/operations.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

Shifting 64-bit value by 64 bits is undefined behaviour. See condition at line 105.

Shifting 64-bit value by 64 bits is undefined behaviour.
See condition at line 105.

Check warning on line 213 in src/to_string.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The address of local variable 'v' might be accessed at non-zero index.

The address of local variable 'v' might be accessed at non-zero index.

Check warning on line 121 in src/to_string.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'buffer_to_base58' is never used.

The function 'buffer_to_base58' is never used.

Check warning on line 406 in src/to_string.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'buffer_to_hex' is never used.

The function 'buffer_to_hex' is never used.

Check warning on line 29 in src/apdu_pubkey.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'get_baking_prompts' is never used.

The function 'get_baking_prompts' is never used.

Check warning on line 22 in src/ui_common.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'io_event' is never used.

The function 'io_event' is never used.

Check warning on line 117 in src/apdu.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'io_exchange_al' is never used.

The function 'io_exchange_al' is never used.

Check warning on line 10 in src/ui_common.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'io_seproxyhal_display' is never used.

The function 'io_seproxyhal_display' is never used.

Check warning on line 54 in src/to_string.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'lookup_parsed_contract_name' is never used.

The function 'lookup_parsed_contract_name' is never used.

Check warning on line 306 in src/to_string.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'microtez_to_string_indirect_no_throw' is never used.

The function 'microtez_to_string_indirect_no_throw' is never used.

Check warning on line 272 in src/to_string.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'number_to_string_indirect64' is never used.

The function 'number_to_string_indirect64' is never used.

Check warning on line 181 in src/to_string.c

See this annotation in the file changed.

@github-actions github-actions / Results of CppCheck

The function 'protocol_hash_to_string' is never used.

The function 'protocol_hash_to_string' is never used.