Add code quality checks #22
spalmer25cppcheck.yml
on: pull_request
cppcheck-annotations
12s
Annotations
23 warnings
|
Redundant code: Found a statement that begins with string constant.:
src/apdu_pubkey.c#L31
Redundant code: Found a statement that begins with string constant.
|
|
Redundant code: Found a statement that begins with string constant.:
src/apdu_pubkey.c#L32
Redundant code: Found a statement that begins with string constant.
|
|
The address of local variable 'main' might be accessed at non-zero index.:
src/apdu_setup.c#L68
The address of local variable 'main' might be accessed at non-zero index.
|
|
The address of local variable 'test' might be accessed at non-zero index.:
src/apdu_setup.c#L71
The address of local variable 'test' might be accessed at non-zero index.
|
|
'data' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.:
src/baking_auth.c#L171
'data' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.
|
|
'fitness' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.:
src/baking_auth.c#L185
'fitness' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.
|
|
'data' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.:
src/baking_auth.c#L185
'data' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.
|
|
'fitness' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.:
src/baking_auth.c#L189
'fitness' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.
|
|
'fitness+fitness_size' is of type 'const void * const'. When using void pointers in calculations, the behaviour is undefined.:
src/baking_auth.c#L189
'fitness+fitness_size' is of type 'const void * const'.
When using void pointers in calculations, the behaviour is undefined.
Arithmetic operations on 'void *' is a GNU C extension, which defines the 'sizeof(void)' to be 1.
|
|
Shifting 64-bit value by 64 bits is undefined behaviour. See condition at line 105.:
src/operations.c#L108
Shifting 64-bit value by 64 bits is undefined behaviour.
See condition at line 105.
|
|
The address of local variable 'v' might be accessed at non-zero index.:
src/to_string.c#L213
The address of local variable 'v' might be accessed at non-zero index.
|
|
The function 'buffer_to_base58' is never used.:
src/to_string.c#L121
The function 'buffer_to_base58' is never used.
|
|
The function 'buffer_to_hex' is never used.:
src/to_string.c#L406
The function 'buffer_to_hex' is never used.
|
|
The function 'get_baking_prompts' is never used.:
src/apdu_pubkey.c#L29
The function 'get_baking_prompts' is never used.
|
|
The function 'io_event' is never used.:
src/ui_common.c#L22
The function 'io_event' is never used.
|
|
The function 'io_exchange_al' is never used.:
src/apdu.c#L117
The function 'io_exchange_al' is never used.
|
|
The function 'io_seproxyhal_display' is never used.:
src/ui_common.c#L10
The function 'io_seproxyhal_display' is never used.
|
|
The function 'lookup_parsed_contract_name' is never used.:
src/to_string.c#L54
The function 'lookup_parsed_contract_name' is never used.
|
|
The function 'microtez_to_string_indirect_no_throw' is never used.:
src/to_string.c#L306
The function 'microtez_to_string_indirect_no_throw' is never used.
|
|
The function 'number_to_string_indirect64' is never used.:
src/to_string.c#L272
The function 'number_to_string_indirect64' is never used.
|
|
The function 'protocol_hash_to_string' is never used.:
src/to_string.c#L181
The function 'protocol_hash_to_string' is never used.
|
|
cppcheck-annotations
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, yuzutech/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
cppcheck-annotations
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|