Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce the custom screensaver #100

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Reintroduce the custom screensaver #100

merged 8 commits into from
Apr 11, 2024

Conversation

spalmer25
Copy link
Collaborator

fixes #98

  • Introduce a low cost display
  • Re-introduce the custom screensaver
  • Run the custom screensaver 20s after signing if no user action

spalmer25 added 3 commits April 9, 2024 16:15
@spalmer25
IO: duplicate the lib_standard_app io_event function for NANOS
1441c29
@spalmer25
UX: introduce low-cost display
d79e392 
Low-cost display disable `TICKER_EVENT` handling.
Low-cost display is deactivated at button push
Low-cost display is activated at signing

As `TICKER_EVENT` handling slows down the application
@spalmer25
Test: check Ledger's screensaver work before signing
838a6de
@spalmer25 spalmer25 added this to the Baking app upgrade milestone Apr 10, 2024
@spalmer25 spalmer25 self-assigned this Apr 10, 2024
@spalmer25 spalmer25 requested a review from ajinkyaraj-23 April 10, 2024 13:28
@spalmer25 spalmer25 marked this pull request as ready for review April 10, 2024 13:28
ajinkyaraj-23
ajinkyaraj-23 reviewed Apr 10, 2024
View reviewed changes
src/ui_screensaver.h Show resolved Hide resolved
src/ui_screensaver.h Outdated Show resolved Hide resolved
src/ui_screensaver.h Outdated Show resolved Hide resolved
src/ui_screensaver.c Outdated Show resolved Hide resolved
@ajinkyaraj-23
Copy link
Collaborator

Did you check with physical nanos? Whether the screensaver goes on after 20s while signing.

@spalmer25
Copy link
Collaborator Author

spalmer25 commented Apr 11, 2024 •
edited
Loading

Did you check with physical nanos? Whether the screensaver goes on after 20s while signing.

Yes, I did. But it would be safer if you checked it too.

@spalmer25 spalmer25 force-pushed the palmer@functori@reintroduce-the-custom-screensaver branch from 76244ff to 6b93eb5 Compare April 11, 2024 07:31
@spalmer25 spalmer25 requested a review from ajinkyaraj-23 April 11, 2024 10:05
ajinkyaraj-23
ajinkyaraj-23 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 886946c into main Apr 11, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

Assignees

@spalmer25 spalmer25

Labels
new-baking-app
Projects
None yet
Milestone
Baking app upgrade
Development

Successfully merging this pull request may close these issues.

UX: reintroduce our custom screensaver
2 participants
@spalmer25 @ajinkyaraj-23