Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: reintroduce our custom screensaver #98

Closed
spalmer25 opened this issue Apr 5, 2024 · 0 comments · Fixed by #100
Closed

UX: reintroduce our custom screensaver #98

spalmer25 opened this issue Apr 5, 2024 · 0 comments · Fixed by #100
Assignees
Labels
bug Something isn't working new-baking-app

Comments

@spalmer25
Copy link
Collaborator

Context

Since commit a21e7b7, the baking application is no longer able to sign baking operations quickly enough.
The signing time for this commit is identical to the previous one (1-2s) but frequently the signing time could increase by 3-6s.

In this commit, our custom io_event function, which overrides the one in Ledger's lib_standard_app, has been removed.
The difference between these two versions of io_event is that TICKER events are not handled in our version.
These events have been reactivated in this commit so that Ledger's screensaver can be used.

But it seems that handling TICKER events slows down the application.

Goal

Stop to handle the TICKER event again and reintroduce our customised screensaver.

@spalmer25 spalmer25 added bug Something isn't working new-baking-app labels Apr 5, 2024
@spalmer25 spalmer25 added this to the Baking app upgrade milestone Apr 5, 2024
@spalmer25 spalmer25 self-assigned this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new-baking-app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant