Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xpetra: fix Xpetra::Tpetra_operator specialization #5294

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Xpetra: fix Xpetra::Tpetra_operator specialization #5294

merged 1 commit into from
Jun 3, 2019

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Jun 3, 2019

@trilinos/xpetra

Description

It looks like the guard in Xpetra_TpetraOperator.hpp for the specialization of the class on EpetraNode does not check that Epetra has been enabled.

Motivation and Context

I am observing build failures when Tpetra has no int and no serial instantiation and Epetra is not enabled.

Related Issues

How Has This Been Tested?

A local build was successfully performed with the problematic configuration.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@lucbv lucbv added type: bug The primary issue is a bug in Trilinos code or tests pkg: Xpetra AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Jun 3, 2019
@lucbv lucbv requested review from cgcgcg, csiefer2 and jhux2 June 3, 2019 17:31
@lucbv lucbv self-assigned this Jun 3, 2019
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 3730
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3545
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1991
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 1766
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1395
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Using Repos:

Repo: TRILINOS (lucbv/Trilinos)
  • Branch: Xpetra_fix_TpetraOperator_spec
  • SHA: f6375a6
  • Mode: TEST_REPO

Pull Request Author: lucbv

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 3730
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3545
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1991
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 1766
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1395
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5294
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Xpetra_fix_TpetraOperator_spec
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f6375a6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 27aed35


CDash Test Results for PR# 5294.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ csiefer2 ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 2efddb4 into trilinos:develop Jun 3, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 5294: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jun 3, 2019
@lucbv lucbv deleted the Xpetra_fix_TpetraOperator_spec branch June 3, 2019 21:33
@lucbv lucbv mentioned this pull request Jun 3, 2019
Closed
@trilinos-autotester trilinos-autotester mentioned this pull request Aug 11, 2021
Merged
@trilinos-autotester trilinos-autotester mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csiefer2 csiefer2 csiefer2 approved these changes

@cgcgcg cgcgcg Awaiting requested review from cgcgcg

@jhux2 jhux2 Awaiting requested review from jhux2

Assignees

@lucbv lucbv

Labels
pkg: Xpetra type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucbv @trilinos-autotester @csiefer2