Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xpetra: Xpetra::Operator uses EpetraNode when Epetra is turned off #5293

Closed
lucbv opened this issue Jun 3, 2019 · 2 comments
Closed

Xpetra: Xpetra::Operator uses EpetraNode when Epetra is turned off #5293

lucbv opened this issue Jun 3, 2019 · 2 comments
Labels
pkg: Xpetra type: bug The primary issue is a bug in Trilinos code or tests

Comments

@lucbv
Copy link
Contributor

lucbv commented Jun 3, 2019

Bug Report

@trilinos/xpetra
@jhux2 @csiefer2

Description

When Trilinos is configure with no int, no serial and Epetra=OFF options, the build fails in Xpetra.
This is due to an issue in the CMake logic in Xpetra::TpetraOperator, it appears that a specialization on EpetraNode is attempted which does not work since Epetra is OFF.
I am proposing that we add a guard to check that Epetra is ON before the specialization is performed. This would also make the code more consistent since the check is performed in the case: GO=long long see Xpetra_TpetraOperator.hpp at lines 198 and 134.

Steps to Reproduce

  "-DTrilinos_ENABLE_Epetra:BOOL=OFF"
  "-DTrilinos_ENABLE_Tpetra:BOOL=ON"
    "-DTpetra_INST_INT_INT:BOOL=OFF"
    "-DTpetra_INST_INT_LONG:BOOL=OFF"
    "-DTpetra_INST_INT_LONG_LONG:BOOL=ON"
    "-DTpetra_INST_SERIAL:BOOL=OFF"
    "-DTrilinos_ENABLE_OpenMP=ON"
  "-DTrilinos_ENABLE_Xpetra:BOOL=ON"
@lucbv lucbv added type: bug The primary issue is a bug in Trilinos code or tests pkg: Xpetra labels Jun 3, 2019
lucbv added a commit to lucbv/Trilinos that referenced this issue Jun 3, 2019
@lucbv
Xpetra: fixing a specialization of the Xpetra::TpetraOperator see issue
f6375a6 
trilinos#5293
@lucbv lucbv mentioned this issue Jun 3, 2019
Merged
9 tasks
@lucbv
Copy link
Contributor Author

lucbv commented Jun 3, 2019

PR #5294 should have fixed the issue.
Let us see if the nightly builds are fixed tomorrow before closing this issue.

jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 4, 2019
Merge 'trilinos/Trilinos:develop' (43d1f7d) into 'tcad-charon/Trilino…
a777acd 
…s:develop' (d1a6821).

* trilinos-develop: (56 commits)
  TrilinosCouplings: More updates for Avatar-as-external-package
  SEACAS: bug fix for may snapshot
  Stk update (trilinos#5289)
  Xpetra: fixing a specialization of the Xpetra::TpetraOperator see issue trilinos#5293
  MueLu: adjusing number of iterations in unit-test to new tolerance
  Tempus: pactch from Empire (trilinos#5282)
  Tpetra: Fix CUDA run-time error in PR trilinos#5280
  Tpetra: Allow CrsMatrix with StaticProfile to resize during import/export (trilinos#5268)
  MueLu: cleaning unit-tests and code for build with Scalar=float
  Ifpack2::Relaxation: Fix signed/unsigned comparison warning
  Teuchos::ScalarTraits: Fix Kokkos::complex specialization macro
  Xpetra: ETI TpetraBlockCrsMatrix bug fixes trilinos#4 (compiles)
  Tpetra: Fix Intel build errors in PR trilinos#5280
  Tpetra: Use trilinos#5279 fix to check Map array/View input
  Tpetra: Use trilinos#5279 fix to check MultiVector (Dual)View input
  Xpetra: ETI TpetraBlockCrsMatrix bug fixes trilinos#3
  Tpetra: Rename headers in fix for trilinos#5279
  Tpetra: Fix trilinos#5279
  Xpetra: ETI TpetraBlockCrsMatrix bug fixes trilinos#2
  Tpetra: Add inMemorySpace & memorySpaceName (part of trilinos#5279)
  ...
@lucbv
Copy link
Contributor Author

lucbv commented Jun 4, 2019

The PR worked fine but shows that there is another issue with the Xpetra MultiVector unit-test.
I will close this issue and open another one for the unit-test.

@lucbv lucbv closed this as completed Jun 4, 2019
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 5, 2019
Merge 'trilinos/Trilinos:develop' (5c4e736) into 'tcad-charon/Trilino…
a6b622a 
…s:develop' (d1a6821).

* trilinos-develop: (69 commits)
  Add Intel 18.0.5 compiler to ATDM environment.
  Fix stk cmake files to disable unit and doc tests that depend on STKNGP_TEST if STKNGP_TEST is not enabled.
  MueLu: removing the Epetra path tests for unit-tests-kokkos, see issue trilinos#4325
  Xpetra: fix MultiVector unit-test for Epetra=OFF configuration, see issue trilinos#5300
  fix another type of quoting error
  TrilinosCouplings: More updates for Avatar-as-external-package
  Correct shell quoting in the package file replacement for python
  SEACAS: bug fix for may snapshot
  Python testing - resolve issues found during testing
  Stk update (trilinos#5289)
  Xpetra: fixing a specialization of the Xpetra::TpetraOperator see issue trilinos#5293
  move gcc 7.2.0 environment back to python2
  MueLu: adjusing number of iterations in unit-test to new tolerance
  Add stand-alone tests for framework python unittests
  Tempus: pactch from Empire (trilinos#5282)
  This commit allows all of the clean_workspace scripts and test to run under both pyython 2 and 3
  test_Modules.py: re-work to run under both python 2 and 3
  Change gcc 7.2 PR testing to use python 3 and disable Modules tests
  Tpetra: Fix CUDA run-time error in PR trilinos#5280
  Tpetra: Allow CrsMatrix with StaticProfile to resize during import/export (trilinos#5268)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 6, 2019
Merge 'trilinos/Trilinos:develop' (4ef1db9) into 'tcad-charon/Trilino…
157107d 
…s:develop' (8380623).

* trilinos-develop: (78 commits)
  MueLu: fixing an issue in the structured region driver data
  Updates to handle when a non RK stepper observer is passed in. (trilinos#5324)
  Xpetra: add forced map writing to unit test
  MueLu: updating some tests/unit_tests, see issue trilinos#5310
  Xpetra: add option to force writing of all maps
  Fixes to make stk build when BoostLib is not enabled.
  Add Intel 18.0.5 compiler to ATDM environment.
  Tpetra: Fix trilinos#4627
  Xpetra: don't write maps unnecessarily
  Fix trilinos#5151.
  Fix stk cmake files to disable unit and doc tests that depend on STKNGP_TEST if STKNGP_TEST is not enabled.
  MueLu: removing the Epetra path tests for unit-tests-kokkos, see issue trilinos#4325
  Xpetra: fix MultiVector unit-test for Epetra=OFF configuration, see issue trilinos#5300
  fix another type of quoting error
  TrilinosCouplings: More updates for Avatar-as-external-package
  Correct shell quoting in the package file replacement for python
  SEACAS: bug fix for may snapshot
  Python testing - resolve issues found during testing
  Stk update (trilinos#5289)
  Xpetra: fixing a specialization of the Xpetra::TpetraOperator see issue trilinos#5293
  ...
@trilinos-autotester trilinos-autotester mentioned this issue Aug 11, 2021
Merged
@trilinos-autotester trilinos-autotester mentioned this issue Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: Xpetra type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucbv