Store remembered device, discovery, accounts, txs in db #713
Conversation
slowbackspace
changed the title
…ite into remember-device-storage
slowbackspace
added
READY FOR REVIEW
| @@ -251,6 +289,26 @@ class CommonDB<TDBStructure> { | |||
| const items = await tx.store.getAll(); | |||
| return items; | |||
There was a problem hiding this comment.
return tx.store.getAll() ?
There was a problem hiding this comment.
and the same in line 285 and 220
| @@ -290,6 +328,26 @@ class CommonDB<TDBStructure> { | |||
| const items = await tx.store.getAll(); | |||
There was a problem hiding this comment.
same as native/index:
return tx.store.getAll() ?
| newVersion: number | null, | ||
| transaction: any | ||
| ) => void; | ||
| db: OnUpgradeProps<TDBStructure>['db'], |
There was a problem hiding this comment.
wouldn't be cleaner to declare this function once?
Since you are using it here and then the same declaration in constructor?
| case DISCOVERY.STOP: | ||
| case DISCOVERY.COMPLETE: { | ||
| // TODO: explore better way to update discovery only | ||
| const device = api.getState().devices.find(d => d.state === action.payload.deviceState); |
There was a problem hiding this comment.
you can use getState().suite.device instead, discovery is designed to run only on currently selected device
There was a problem hiding this comment.
wait :) i don't get why you are saving device instead of discovery?
There was a problem hiding this comment.
rememberDevice should be triggered from SUITE.REMEMBER_DEVICE, right?
There was a problem hiding this comment.
- additionaly device should be updated after DEVICE.UPDATE as well, for example changing label/FW/pin/passphrase settings
slowbackspace
added
in progress
and removed
READY FOR REVIEW
slowbackspace
added
READY FOR REVIEW
fix #745
part of #8 (web/electron covered)