Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests failing with Node.js v11+ #745

Closed
slowbackspace opened this issue Oct 31, 2019 · 0 comments · Fixed by #713
Closed

Unit tests failing with Node.js v11+ #745

slowbackspace opened this issue Oct 31, 2019 · 0 comments · Fixed by #713
Assignees
@slowbackspace
Labels
bug Something isn't working as expected
Milestone
Sprint 01

Comments

@slowbackspace
Copy link
Contributor

slowbackspace commented Oct 31, 2019 •
edited
Loading

I started using node v12 in my branch because I use some killer bleeding-edge features (array.flat lol) and jest wouldn't let me use it otherwise. But since then our unit tests started failing. The cause is change dsort algo (it is stable now 🎉) in the V8, shipped in Node.js v11.

I will fix the tests in my branch and after merging the branch we can bump the required node version to 12.

https://www.reddit.com/r/javascript/comments/9sb87m/chrome_70_and_nodejs_11_no_longer_sort_arrays/
nodejs/node#22754 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slowbackspace slowbackspace

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
Sprint 01
Development

Successfully merging a pull request may close this issue.

Store remembered device, discovery, accounts, txs in db trezor/trezor-suite
1 participant
@slowbackspace