Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-desktop): app reset on mac #14727

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix(suite-desktop): app reset on mac #14727

merged 1 commit into from
Oct 8, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Oct 4, 2024

This appears to fix #14480 but I bet it also breaks something else.

Maybe @martykan has a clue. Also if it only hinders autostart feature but fixes the aforementioned regression, it is probably still ok to merge it since the autostart feature is still kind of experimental and hidden in debug mode.

@MiroslavProchazka MiroslavProchazka added the build-desktop This will trigger the build of desktop apps for your PR label Oct 7, 2024
@MiroslavProchazka MiroslavProchazka marked this pull request as ready for review October 8, 2024 07:41
@MiroslavProchazka MiroslavProchazka self-requested a review October 8, 2024 07:41
Copy link
Contributor

@MiroslavProchazka MiroslavProchazka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by QA here

@marekrjpolak marekrjpolak merged commit a682ea6 into develop Oct 8, 2024
18 checks passed
@marekrjpolak marekrjpolak deleted the fix-mac-restart branch October 8, 2024 08:19
@martykan
Copy link
Member

martykan commented Oct 9, 2024

Yeah this doesn't work with autostart, will look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-desktop This will trigger the build of desktop apps for your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset storage button in Settings/Application does not do anything
4 participants