Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suite doesn't relaunch on "Reset app" on Linux #5055

Closed
STew790 opened this issue Mar 4, 2022 · 14 comments · Fixed by #5149, #10399 or #14779
Closed

Suite doesn't relaunch on "Reset app" on Linux #5055

STew790 opened this issue Mar 4, 2022 · 14 comments · Fixed by #5149, #10399 or #14779
Labels
bug Something isn't working as expected Linux Linux related QA OK Issue passed QA without any blocker

Comments

@STew790
Copy link
Contributor

STew790 commented Mar 4, 2022

Describe the bug
Suite doesn't relaunch when I try to "Reset app" in settings on Linux Ubuntu. (On NixOS it works correctly)

Steps to reproduce:

  1. Start Suite
  2. Go to settings
  3. Click on "Reset app"
  4. App will quit but won't relaunch

Info:

  • Suite version: 22.2.3 (4dc44f6)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.102 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model 1 1.10.5 regular

Expected result:
App will relaunch.

Actual result:
App just quits and won't relaunch.

@STew790 STew790 added the bug Something isn't working as expected label Mar 4, 2022
@tomasklim
Copy link
Member

tomasklim commented Mar 4, 2022

Probably a working fix. Tested with @STew790 electron-userland/electron-builder#1727 (comment)

// modified Suite app/restart handler
ipcMain.on('app/restart', () => {
    logger.info('main', 'App restart requested');
    const options: RelaunchOptions = {};
    options.args = process.argv.slice(1).concat(['--relaunch']);
    options.execPath = process.execPath;
    if (process.env.APPIMAGE) {
        options.execPath = process.env.APPIMAGE;
        options.args.unshift('--appimage-extract-and-run');
    }
    app.relaunch(options);
    app.exit(0);
});

Would be nice if someone with Linux Ubuntu tries it again @mroz22
Has to be tested on all OS.

@tomasklim tomasklim added the Linux Linux related label Mar 4, 2022
@tomasklim tomasklim linked a pull request Mar 18, 2022 that will close this issue
@hynek-jina hynek-jina moved this to 🤝 Needs QA in Issues Suite Mar 25, 2022
@STew790
Copy link
Contributor Author

STew790 commented Mar 25, 2022

QA OK

App relaunched correctly when I clicked on "Reset app"

Info:

  • Suite version: app 22.4.0 (35d3fb4)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.4.0 Chrome/94.0.4606.81 Electron/15.3.0 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.4.4 regular

@hynek-jina hynek-jina moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Mar 25, 2022
@STew790
Copy link
Contributor Author

STew790 commented Nov 9, 2022

QA NOK
This issue is back, app can't be restarted by "Reset app".

Info:

  • Suite version: desktop 22.11.1 (73ccf72)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.11.1 Chrome/100.0.4896.160 Electron/18.3.5 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device:
  • Transport: bridge 2.0.32

@STew790 STew790 reopened this Nov 9, 2022
@hynek-jina hynek-jina removed the status in Issues Suite Nov 9, 2022
@hynek-jina hynek-jina moved this to 🎯 To do in Issues Suite Nov 9, 2022
@sime sime removed their assignment Nov 14, 2022
@matejkriz
Copy link
Member

note from @szymonlesisz , the app can be restarted but it starts disconnected from the console on nixos with appimage-run

@matejkriz
Copy link
Member

Still NOK on Ubuntu 22.04.1 LTS

@matejkriz matejkriz removed the status in Issues Suite Feb 2, 2023
@matejkriz matejkriz moved this to 🎯 To do in Issues Suite Feb 2, 2023
@matejkriz matejkriz moved this from 🎯 To do to 🔎 Needs review in Issues Suite Feb 2, 2023
@matejkriz matejkriz moved this from 🔎 Needs review to 🎯 To do in Issues Suite Feb 2, 2023
@sime sime removed the status in Issues Suite Feb 9, 2023
@hynek-jina hynek-jina moved this to 🎯 To do in Issues Suite Feb 9, 2023
@matejkriz
Copy link
Member

@trezor/qa could you please retest because we updated the Electron recently?

@bosomt
Copy link
Contributor

bosomt commented Mar 30, 2023

@matejkriz tested multiple times on KUbuntu with 6e3b942 no luck, app never relaunches after reset is triggered from app settings.

@matejkriz
Copy link
Member

@bosomt thanks for verification 👍

@STew790
Copy link
Contributor Author

STew790 commented Jul 20, 2023

QA NOK
Unfortunately, this is still present.

Info:

  • Suite version: desktop 23.8.0 (24120f1)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/23.8.0 Chrome/112.0.5615.204 Electron/24.5.1 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.6.0 Universal (revision 88e1f8c7a5c7615723664c64b0a25adc0c409dee)
  • Transport: BridgeTransport 2.0.33

@STew790
Copy link
Contributor Author

STew790 commented Dec 12, 2023

Not sure if it helps but when I was updating from 0.23.12 version to 23.11.5 (part of the autoupdate test) the Suite actually DID restart itself after the update downloaded the new version and I clicked on "Restart and update", which wasn't happening before because of this issue.
Nonetheless, the "Reset app" button still does not restart the app (but it still does reset it).

@STew790
Copy link
Contributor Author

STew790 commented Feb 14, 2024

QA NOK
Sadly, this is still not working.

Info:

  • Suite version: desktop 24.3.0 (8be1f80)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.3.0 Chrome/118.0.5993.129 Electron/27.0.4 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: Trezor T2T1 2.6.4 regular (revision 42e9ed0e09033d474dee1a560fe5870646fa440e)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to 🎯 To do in Issues Suite Feb 20, 2024
@bosomt bosomt reopened this Feb 20, 2024
@STew790
Copy link
Contributor Author

STew790 commented Feb 26, 2024

Soo, the app again restarted for me when updating from 24.2.2 > 24.2.3 if that helps to solve this.

@matejkriz matejkriz added the QA NOK Issue doesn't pass the QA and some changes are needed. label Aug 21, 2024
@STew790
Copy link
Contributor Author

STew790 commented Oct 8, 2024

Seems like this issue might have been fixed by this #14727
I will wait for the merge and test it again just to be sure.

@STew790
Copy link
Contributor Author

STew790 commented Nov 7, 2024

QA OK
It is working again 🎉

Info:

  • Suite version: desktop 24.11.1 (9e9dadf)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.11.1 Chrome/128.0.6613.162 Electron/32.1.2 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device:
  • Transport: BridgeTransport 2.0.33

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Nov 7, 2024
@STew790 STew790 added QA OK Issue passed QA without any blocker and removed QA NOK Issue doesn't pass the QA and some changes are needed. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected Linux Linux related QA OK Issue passed QA without any blocker
Projects
Archived in project
6 participants