Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mock usage for dispatch #946

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Replace mock usage for dispatch #946

merged 3 commits into from
Nov 3, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Nov 3, 2022 •
edited
Loading

Description

Remove mock usage on commanded dispatched usages. I will send the removal of the DateTime mock in a next PR

How was this tested?

Using Mox instead of Mock

@arbulu89 arbulu89 marked this pull request as ready for review November 3, 2022 07:41
fabriziosestito
fabriziosestito approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the mock dependency and clean the mix.lock

otherwise, LGTM!

config/test.exs Show resolved Hide resolved
@arbulu89
Copy link
Contributor Author

arbulu89 commented Nov 3, 2022

@fabriziosestito

We can remove the mock dependency and clean the mix.lock

Not yet, I need to remove some other mocks used with DateTime XD

@arbulu89 arbulu89 merged commit 481be8a into main Nov 3, 2022
@arbulu89 arbulu89 deleted the replace-mock-usage-for-dispatch branch November 3, 2022 08:04
@arbulu89 arbulu89 mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@nelsonkopliku nelsonkopliku Awaiting requested review from nelsonkopliku

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
tech debt
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arbulu89 @fabriziosestito