Replace mock usage for dispatch (#946)

* Use CommandAuditMiddleware to test the commands

* Use adapter on commanded dispatch to improve testability

* Inactivate heartbeat checker scheduler in test mode

config/config.exs

@@ -53,6 +53,8 @@ config :logger, :console,
 # Use Jason for JSON parsing in Phoenix
 config :phoenix, :json_library, Jason
 
+config :trento, Trento.Commanded, adapter: Trento.Commanded
+
 config :trento, Trento.Commanded,
   event_store: [
     adapter: Commanded.EventStore.Adapters.EventStore,

config/test.exs

@@ -70,6 +70,13 @@ config :trento, Trento.Integration.Checks.Wanda.Messaging.AMQP,
     ]
   ]
 
+config :trento, Trento.Scheduler,
+  jobs: [
+    heartbeat_check: [
+      state: :inactive
+    ]
+  ]
+
 config :trento,
   extra_children: [
     Trento.Messaging.Adapters.AMQP.Publisher,

lib/trento/application/event_handlers/rollup_event_handler.ex

@@ -26,6 +26,9 @@ defmodule Trento.RollupEventHandler do
   defp after_max_retries_reached(%ClusterRolledUp{cluster_id: cluster_id}, _, _) do
     %{cluster_id: cluster_id}
     |> AbortClusterRollup.new!()
-    |> Trento.Commanded.dispatch()
+    |> commanded().dispatch()
   end
+
+  defp commanded,
+    do: Application.fetch_env!(:trento, Trento.Commanded)[:adapter]
 end

lib/trento/application/integration/checks/checks.ex

@@ -59,7 +59,7 @@ defmodule Trento.Integration.Checks do
       }) do
     case StartChecksExecution.new(%{cluster_id: cluster_id}) do
       {:ok, command} ->
-        Trento.Commanded.dispatch(command, correlation_id: execution_id)
+        commanded().dispatch(command, correlation_id: execution_id)
 
       error ->
         error
@@ -74,12 +74,15 @@ defmodule Trento.Integration.Checks do
     with {:ok, execution_completed_event} <- ExecutionCompletedEventDto.new(payload),
          {:ok, command} <-
            build_complete_checks_execution_command(execution_completed_event) do
-      Trento.Commanded.dispatch(command, correlation_id: execution_id)
+      commanded().dispatch(command, correlation_id: execution_id)
     end
   end
 
   def handle_callback(_), do: {:error, :invalid_payload}
 
+  defp commanded,
+    do: Application.fetch_env!(:trento, Trento.Commanded)[:adapter]
+
   defp adapter,
     do: Application.fetch_env!(:trento, __MODULE__)[:adapter]
 

lib/trento/application/integration/discovery/discovery.ex

@@ -127,7 +127,7 @@ defmodule Trento.Integration.Discovery do
   @spec dispatch(command | [command]) :: :ok | {:error, any}
   defp dispatch(commands) when is_list(commands) do
     Enum.reduce(commands, :ok, fn command, acc ->
-      case {Trento.Commanded.dispatch(command), acc} do
+      case {commanded().dispatch(command), acc} do
         {:ok, :ok} ->
           :ok
 
@@ -140,5 +140,8 @@ defmodule Trento.Integration.Discovery do
     end)
   end
 
-  defp dispatch(command), do: Trento.Commanded.dispatch(command)
+  defp dispatch(command), do: commanded().dispatch(command)
+
+  defp commanded,
+    do: Application.fetch_env!(:trento, Trento.Commanded)[:adapter]
 end

lib/trento/application/usecases/clusters/clusters.ex

@@ -29,21 +29,21 @@ defmodule Trento.Clusters do
              host_id: host_id,
              checks_results: build_check_results(checks_results)
            }) do
-      Trento.Commanded.dispatch(command)
+      commanded().dispatch(command)
     end
   end
 
   @spec select_checks(String.t(), [String.t()]) :: :ok | {:error, any}
   def select_checks(cluster_id, checks) do
     with {:ok, command} <- SelectChecks.new(%{cluster_id: cluster_id, checks: checks}) do
-      Trento.Commanded.dispatch(command)
+      commanded().dispatch(command)
     end
   end
 
   @spec request_checks_execution(String.t()) :: :ok | {:error, any}
   def request_checks_execution(cluster_id) do
     with {:ok, command} <- RequestChecksExecution.new(%{cluster_id: cluster_id}) do
-      Trento.Commanded.dispatch(command)
+      commanded().dispatch(command)
     end
   end
 
@@ -96,6 +96,9 @@ defmodule Trento.Clusters do
     end)
   end
 
+  defp commanded,
+    do: Application.fetch_env!(:trento, Trento.Commanded)[:adapter]
+
   @spec build_check_results([String.t()]) :: {:ok, [CheckResult.t()]} | {:error, any}
   defp build_check_results(checks_results) do
     Enum.map(checks_results, fn c ->

lib/trento/application/usecases/hosts/heartbeats.ex

@@ -56,12 +56,15 @@ defmodule Trento.Heartbeats do
   defp dispatch_command(agent_id, heartbeat) do
     case %{host_id: agent_id, heartbeat: heartbeat}
          |> UpdateHeartbeat.new!()
-         |> Trento.Commanded.dispatch() do
+         |> commanded().dispatch() do
       :ok ->
         {:ok, :done}
 
       {:error, _} = error ->
         error
     end
   end
+
+  defp commanded,
+    do: Application.fetch_env!(:trento, Trento.Commanded)[:adapter]
 end

test/support/factory.ex

@@ -41,6 +41,7 @@ defmodule Trento.Factory do
     ClusterReadModel,
     DatabaseInstanceReadModel,
     DatabaseReadModel,
+    Heartbeat,
     HostChecksExecutionsReadModel,
     HostConnectionSettings,
     HostReadModel,
@@ -102,6 +103,13 @@ defmodule Trento.Factory do
     }
   end
 
+  def heartbeat_factory do
+    %Heartbeat{
+      agent_id: Faker.UUID.v4(),
+      timestamp: DateTime.utc_now()
+    }
+  end
+
   def host_connection_settings_factory do
     %HostConnectionSettings{
       id: Faker.UUID.v4(),

test/test_helper.exs

@@ -1,3 +1,7 @@
+Mox.defmock(Trento.Commanded.Mock, for: Commanded.Application)
+
+Application.put_env(:trento, Trento.Commanded, adapter: Trento.Commanded.Mock)
+
 Mox.defmock(Trento.Integration.Telemetry.Mock, for: Trento.Integration.Telemetry.Gen)
 
 Application.put_env(:trento, Trento.Integration.Telemetry,