-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend table filters from query string #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! As I said, I like the ability of enabling/disabling the search params per column. I made some minor comments, let me know if you agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things to improve but generally speaking, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This pr derives from the pr #908, following @rtorrero proposal on query string filters feature.
This pr enables all the tables in trento webapp application to be filtered with query string parameters.
The configuration is declarative and enables these capabilities with option fields on columns.
Demo
Configuration examples:
filter
field andfilterFromParams
field should be present.You can enable the filters an all columns and filters type.
For demo/feature purpose the sid and tags filters are enabled with query string on HostOverview screen.
How was this tested?
E2E testing with cypress, the component is compliant to unit testing with jest, but for pure testing purposes the filtering capabilities are tested with an e2e tests on the HostOverview screen with SID and Tags filters.