Add filtering through search params #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtorrero
added
enhancement
rtorrero
force-pushed
the
add-searchparams-filtering-hosts
branch
from
056faea to
f1e3873
Compare
rtorrero
commented
Oct 19, 2022
dottorblaster
suggested changes
Oct 19, 2022
CDimonaco
reviewed
Oct 20, 2022
rtorrero
force-pushed
the
add-searchparams-filtering-hosts
branch
from
4dd6151 to
a2bee8d
Compare
|
Since PR #925 has already been merged and included improvements over the work that I did here, I've removed one of my commits and rebased. Should be good now. |
nelsonkopliku
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was initially supposed to just add linking from the dashboard to the hosts view with filters set in the search params, but after starting, it was clear that by allowing the filter component to handle the search params we could enable it in every view.
@CDimonaco actually has another approach on the works, if that works/looks better we can just close this, I just didn't want so many hours of bashing my head against the keyboard to end in nothing 😄
How was this tested?
A new e2e test was added to check that the link from the dashboard includes the filter preset.