Enable/disable charts feature #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
added
enhancement
CDimonaco
force-pushed
the
enable_disable_charts
branch
from
8369197 to
a3c26cc
Compare
arbulu89
reviewed
Jan 9, 2024
| data-testid="chart-disabled-box" | ||
| > | ||
| <h2 className="font-bold text-center text-xl"> | ||
| Charts are disabled, please check documentation for further details |
There was a problem hiding this comment.
Maybe Charts are disabled. Please check the documentation for further details.
Could we point the user to that documentation with a link?
Otherwise it doesn't look like that helpful
There was a problem hiding this comment.
Yes, but we don't have the docs yet, so atm I think we could have as is
arbulu89
approved these changes
Jan 9, 2024
assets/js/common/ChartsDisabledBox/ChartsDisabledBox.stories.jsx
Outdated
Show resolved
Hide resolved
CDimonaco
force-pushed
the
enable_disable_charts
branch
from
d67a6b0 to
f42b77c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr aims to enable and disable the charts feature, both in the backend/frontend.
By default the feature is enabled, can be disabled with a runtime env variable.
On the backend, a dedicated plug will return 501 for all the charts endpoint, when the feature is disabled.
On frontend, the chart components will not be displayed, instead a text with a dedicated copy is shown to the user.
Frontend result
How was this tested?
Automated tests