Addressing review feedbacks

trento-project · Jan 9, 2024 · d67a6b0 · d67a6b0
1 parent a3c26cc
commit d67a6b0
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 12 deletions.
diff --git a/assets/js/common/ChartDisabledBox/index.js b/assets/js/common/ChartDisabledBox/index.js
diff --git a/assets/js/common/ChartFeatureWrapper/ChartFeatureWrapper.jsx b/assets/js/common/ChartFeatureWrapper/ChartFeatureWrapper.jsx
@@ -1,9 +1,9 @@
 import React from 'react';
-import ChartDisabledBox from '@common/ChartDisabledBox';
+import ChartsDisabledBox from '@common/ChartsDisabledBox';
 
 function ChartFeatureWrapper({ children }) {
   // eslint-disable-next-line no-undef
-  if (!config.chartsEnabled) return <ChartDisabledBox />;
+  if (!config.chartsEnabled) return <ChartsDisabledBox />;
   return children;
 }
 

diff --git a/...mon/ChartDisabledBox/ChartDisabledBox.jsx → ...n/ChartsDisabledBox/ChartsDisabledBox.jsx b/...mon/ChartDisabledBox/ChartDisabledBox.jsx → ...n/ChartsDisabledBox/ChartsDisabledBox.jsx
@@ -1,6 +1,6 @@
 import React from 'react';
 
-function ChartDisabledBox() {
+function ChartsDisabledBox() {
   return (
     <div
       className="mt-4 bg-white shadow rounded-lg py-4 px-8 mx-auto"
@@ -13,4 +13,4 @@ function ChartDisabledBox() {
   );
 }
 
-export default ChartDisabledBox;
+export default ChartsDisabledBox;
diff --git a/...tDisabledBox/ChartDisabledBox.stories.jsx → ...DisabledBox/ChartsDisabledBox.stories.jsx b/...tDisabledBox/ChartDisabledBox.stories.jsx → ...DisabledBox/ChartsDisabledBox.stories.jsx
diff --git a/assets/js/common/ChartsDisabledBox/index.js b/assets/js/common/ChartsDisabledBox/index.js
@@ -0,0 +1,3 @@
+import ChartsDisabledBox from './ChartsDisabledBox';
+
+export default ChartsDisabledBox;
diff --git a/lib/trento_web/plugs/charts_disabled_plug.ex b/lib/trento_web/plugs/charts_disabled_plug.ex
@@ -1,8 +1,8 @@
 defmodule TrentoWeb.Plugs.ChartsDisabledPlug do
   @moduledoc """
-    This plug will act as a barrier for the charts endpoint, will return 501 for all the requests.
+    This plug acts as a barrier for the charts endpoint, will return 501 for all the requests.
 
-    The endpoints will be accessible only if the ":trento, Trento.Charts, enabled" configuration entry is properly set.
+    The endpoints are accessible only if the ":trento, Trento.Charts, enabled" configuration entry is properly set.
 
     The plug itself is mounted only when the charts are disabled in the configuration.
   """

diff --git a/.../plugs/unplug_charts_enabled_predicate.ex → ...lugs/unplug/predicates/charts_disabled.ex b/.../plugs/unplug_charts_enabled_predicate.ex → ...lugs/unplug/predicates/charts_disabled.ex
@@ -1,4 +1,4 @@
-defmodule TrentoWeb.Plugs.UnplugChartsEnabledPredicate do
+defmodule TrentoWeb.Plugs.Unplug.Predicates.ChartsDisabled do
   @moduledoc false
 
   @behaviour Unplug.Predicate

diff --git a/lib/trento_web/router.ex b/lib/trento_web/router.ex
@@ -45,7 +45,7 @@ defmodule TrentoWeb.Router do
 
   pipeline :charts_feature do
     plug Unplug,
-      if: TrentoWeb.Plugs.UnplugChartsEnabledPredicate,
+      if: TrentoWeb.Plugs.Unplug.Predicates.ChartsDisabled,
       do: TrentoWeb.Plugs.ChartsDisabledPlug
   end
 

diff --git a/...o_web/plugs/charts_disabled_plug_test.exs → ...ugs/unplug/predicates/charts_disabled.exs b/...o_web/plugs/charts_disabled_plug_test.exs → ...ugs/unplug/predicates/charts_disabled.exs
@@ -1,4 +1,4 @@
-defmodule TrentoWeb.Plugs.ChartsDisabledPlugTest do
+defmodule TrentoWeb.Plugs.Unplug.Predicates.ChartsDisabledTest do
   use TrentoWeb.ConnCase, async: true
   use Plug.Test
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import ChartsDisabledBox from './ChartsDisabledBox';

		export default ChartsDisabledBox;