Fix 404 page when wrong filtered catalog is being used in execution results page #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
force-pushed
the
fix_grouped_ckeck_results_view
branch
3 times, most recently
from
9075970 to
5c91169
Compare
EMaksy
changed the title
EMaksy
added
bug
EMaksy
force-pushed
the
fix_grouped_ckeck_results_view
branch
from
5c91169 to
4304ee7
Compare
EMaksy
force-pushed
the
fix_grouped_ckeck_results_view
branch
2 times, most recently
from
f0c5e28 to
2e43e0d
Compare
dottorblaster
suggested changes
May 16, 2023
EMaksy
force-pushed
the
fix_grouped_ckeck_results_view
branch
from
1261bb6 to
016ebd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a bug that occurs when navigating to the checks catalog view and selecting a provider filter (e.g., "gcp," "kvm," or "aws") different from the previously executed provider. Proceeding to the cluster details view and clicking the "Show Results" button, a 404 error page is encountered.
The underlying issue is a slow loading of the catalog, which triggers the error. To resolve this behavior, the pull request introduces several changes. Firstly, a loading state is implemented to improve data handling and ensure proper catalog loading. Additionally, the loading transition is enhanced by incorporating the LoadingBox component, resulting in a smoother user experience.
Before Fix
Bug.webm
After Fix
bugFix.webm