Add WIP for fix

trento-project · May 15, 2023 · 9075970 · 9075970
1 parent bee8a43
commit 9075970
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 8 deletions.
diff --git a/assets/js/components/ExecutionResults/ExecutionResults.jsx b/assets/js/components/ExecutionResults/ExecutionResults.jsx
@@ -7,6 +7,7 @@ import HealthIcon from '@components/Health';
 import Modal from '@components/Modal';
 import PremiumPill from '@components/PremiumPill';
 import Table from '@components/Table';
+import LoadingBox from '@components/LoadingBox';
 import {
   getCatalogCategoryList,
   getCheckResults,
@@ -116,6 +117,15 @@ function ExecutionResults({
       onLastExecutionUpdate();
     }
   };
+  console.log(
+    'catalog length',
+    catalog.length,
+    'catalog loading',
+    catalogLoading
+  );
+  if (catalogLoading) {
+    return <LoadingBox text="Loading checks catalog" />;
+  }
 
   const checksResults = getCheckResults(executionData);
   const catalogCategoryList = getCatalogCategoryList(catalog, checksResults);

diff --git a/assets/js/components/ExecutionResults/ExecutionResultsPage.jsx b/assets/js/components/ExecutionResults/ExecutionResultsPage.jsx
@@ -12,6 +12,7 @@ import {
   RUNNING_STATES,
 } from '@state/lastExecutions';
 import ExecutionResults from './ExecutionResults';
+import LoadingBox from '../LoadingBox';
 
 function ExecutionResultsPage() {
   const { clusterID } = useParams();
@@ -40,7 +41,7 @@ function ExecutionResultsPage() {
   }, [cloudProvider]);
 
   if (!cluster) {
-    return <div>Loading...</div>;
+    return <LoadingBox text="Loading ..." />;
   }
 
   return (

diff --git a/assets/js/components/ExecutionResults/checksUtils.js b/assets/js/components/ExecutionResults/checksUtils.js
@@ -42,13 +42,20 @@ export const getCatalogCategoryList = (catalog, checksResults = []) => {
   if (!catalog || catalog.length === 0 || !checksResults) {
     return [];
   }
-  return [
-    ...new Set(
-      checksResults.map(
-        ({ check_id }) => catalog.find((check) => check.id === check_id).group
-      )
-    ),
-  ].sort();
+  console.log(
+    'getCatalogCategoryList catalog ',
+    catalog,
+    'checksResults ',
+    checksResults
+  );
+  const uniqueGroups = checksResults
+    .map(({ check_id }) => {
+      const check = catalog.find((check) => check.id === check_id);
+      return check ? check.group : undefined;
+    })
+    .filter(Boolean);
+
+  return [...new Set(uniqueGroups)].sort();
 };
 
 export const getCheckDescription = (catalog, checkID) => {

diff --git a/assets/js/state/selectors/lastExecutions.js b/assets/js/state/selectors/lastExecutions.js
@@ -39,6 +39,7 @@ export const getLastExecutionData = (groupID) => (state) => {
   const clusterHosts = getClusterHosts(groupID)(state);
   const cluster = getCluster(groupID)(state);
   const catalog = getCatalog()(state);
+  console.log('catalog', catalog, 'catalog loading', catalog.loading);
   const lastExecution = getLastExecution(groupID)(state) || null;
 
   const enrichedExecution = lastExecution