-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sure queries are copied to the right place #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Don't merge this yet, this should be failing, so something still isn't right. EDIT: Alright so this does catch them now. I'll sync some stuff that nvim doesn't have yet first in nvim-treesitter/nvim-treesitter#4920, and then I'll sync back the other way because we are missing a change from there as well. Then I'll update this and it should be 🟢 . |
I noticed that the queries in nvim-treesitter and this repo have diverged, but we never got an error here. I think this was a regression introduced in tree-sitter@7d348f5.
These should be the same now after nvim-treesitter/nvim-treesitter#4926
So I sort of forgot about this, but it's failing right now and it's somewhat expected. Basically some of the improvements that were added by @ghostbuster91 in #196 are great and they follow the upstream locals way of doing things. However, this is one area where nvim-treesitter differs. So if we sync the local queries here, it won't be quite as accurate. I'm sort of inclined to update the check to only check against the actual |
I'd suggest being explicit about the fact that queries are system-specific (as far as I remember, there are also nvim-specific captures for highlights, not only locals). For example, we could have a structure like
And check only In this scheme queries from |
👍 I would not revert the changes in the |
Just commenting that I haven't forgotten about this, 😬 just been busy lately with other things. I'll try to return soon. |
Closing this just because I won't have time to work on it. |
I noticed that the queries in nvim-treesitter and this repo have
diverged, but we never got an error here. I think this was a regression
introduced in
7d348f5.