fix: Incorrect string interpolation highlighting group #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
Mar 12, 2023
| @@ -141,9 +141,9 @@ class Copier: | |||
|
|
|||
| export scanUnit.scan | |||
| // ^ include | |||
| // ^namespace | |||
| // ^variable | |||
eed3si9n
reviewed
Mar 12, 2023
| @@ -57,7 +57,7 @@ object Hello { | |||
| // ^ keyword | |||
| // ^ type | |||
| self: X => | |||
| // ^type | |||
| // ^parameter | |||
eed3si9n
approved these changes
Mar 12, 2023
Indeed, that new query file had to be added in couple different places. But the build still fails 🤔 |
This is because we have a check to make sure our queries match the queries in nvim-treesitter just to warn us if they go out of sync. Since you're introducing more queries here that's sort of expected to fail. No worries on that. After we merge this I'll sync the queries here with those. |
|
@ckipp01 hmm, I modified slightly the build process and it passes now :D |
ckipp01
added a commit
to ckipp01/nvim-treesitter
that referenced
this pull request
Mar 27, 2023
This syncs the queries that were updated in tree-sitter/tree-sitter-scala#196.
ckipp01
added a commit
to ckipp01/nvim-treesitter
that referenced
this pull request
Mar 27, 2023
This syncs the queries that were updated in tree-sitter/tree-sitter-scala#196. Co-authored-by: ghostbuster91 <[email protected]>
amaanq
pushed a commit
to ckipp01/nvim-treesitter
that referenced
this pull request
Mar 27, 2023
This syncs the queries that were updated in tree-sitter/tree-sitter-scala#196. Co-authored-by: ghostbuster91 <[email protected]>
amaanq
pushed a commit
to nvim-treesitter/nvim-treesitter
that referenced
this pull request
Mar 27, 2023
This syncs the queries that were updated in tree-sitter/tree-sitter-scala#196. Co-authored-by: ghostbuster91 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that values from interpolated strings are not highlighted correctly:
In order to have correct hl (highlight) group assigned I had to introduce scope tracking feature from the treesitter. After that some hl tests started failing.
Since some of the changes might be controversial I breakdown them here:
in
self: X =>selfhad atypehl group previously. I dunno why. I changed it toparameterin
export scanUnit.scanscanUnitwas anamespacebut it is declared few lines above as a variable hence it should has the same hl group as its definition.According to the treesitter documentation:
(interpolation) @nonewas too wide and I couldn't get it to work with the rest of the changes, so I narrowed it.