Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "reverse virtuallist refactor" #5255

Closed
wants to merge 34 commits into from
Closed

Revert "reverse virtuallist refactor" #5255

wants to merge 34 commits into from

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Jun 17, 2024

pulled out from #5061 (do not merge before)

mifi and others added 30 commits March 19, 2024 23:01
@mifi
add google photos frontend
5f6af38
@mifi
implement google photos
62312be 
in companion
- make one authProvider for each of drive/googlephotos, because reusing would have been a big rewrite
- allow the provider.download method to optionally return a size as an optimization
@mifi
merge main
f27b1f1
@mifi
Merge branch 'main' into google-photos
6d94531
@mifi
separate virtualList from loadAllFiles
bf2a494 
they are different concept
and virtual list doesn't support grid
@mifi
convert virtuallist to TS
11dfff4
@mifi
add missing file
17d3e91
@aduh95
Merge branch 'main' of https://github.com/transloadit/uppy
759ee74
@mifi @aduh95
document google photos
702ed84 
see #5061
@aduh95
lint
ca78a48
@mifi
prettier
94f294e
@mifi
Merge branch 'main' into google-photos
63fdbd7
@mifi
Merge branch 'main' into google-photos
339e835 
# Conflicts:
#	packages/@uppy/provider-views/src/ProviderView/ProviderView.tsx
@mifi
merge main
67f6d0d
@mifi
run format
701f2eb
@mifi
fix lint
fdc1662
@mifi
implement user info
d0763f1 
as required by google
@mifi
Merge branch 'main' into google-photos
aa09ad0
@mifi
fix tests
f65edd7
@mifi
fix codesandbox
7792dcc
@mifi
remove accidental js file
345383e
@mifi
fix test
e8429f7
@mifi
fix ts
cf2025d
@mifi
fix ts
0dba1bb
@mifi
fix ts
0c21a5e
@mifi
don't use inheritance
08beacc 
#5061 (comment)
@mifi
remove GooglePhotosProviderViews
371a7e2
@mifi
git merge main
03b1d95
@mifi
use folder icon for albums
503203b 
#5061 (comment)
@mifi
fix test
eb18350
@mifi mifi mentioned this pull request Jun 17, 2024
Merged
11 tasks
@github-actions GitHub Actions
Copy link
Contributor

Diff output files 
No diff

Base automatically changed from google-photos to main June 18, 2024 09:13
@aduh95
Copy link
Contributor

aduh95 commented Jun 27, 2024

What's the status here Mikael?

@aduh95 aduh95 marked this pull request as draft July 2, 2024 13:37
@lakesare
Copy link
Contributor

lakesare commented Jul 3, 2024

The reason we have performance issues (can reproduce in 4.x too) is because we lost the functionality of VirtualList somewhere along the way. All performance issues disappear when we limit the number of rendered rows to, e.g., 100 rows (everything else stays the same - we process 10k files, etc., only the number of rendered files matters for performance).

Proof

Here is GoogleDrive in 4.x branch, virtualList option is true, and yet 1500 items are all rendered:

Screenshot 2024-07-03 at 17 03 41

Here is what it should look like instead: https://jsfiddle.net/developit/qqan9pdo.

@mifi, would you like to debug our VirtualList implementation while you're refactoring it?

@lakesare lakesare self-requested a review July 3, 2024 12:09
@mifi mifi mentioned this pull request Jul 3, 2024
Open
1 task
@mifi
Copy link
Contributor Author

mifi commented Jul 3, 2024

recreated as #5307 because i dunno what happened here. Also included your TODO @lakesare

@mifi mifi closed this Jul 3, 2024
@aduh95 aduh95 deleted the tsify-virtuallist branch July 5, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakesare lakesare Awaiting requested review from lakesare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mifi @aduh95 @lakesare