companion: allow providing any S3 option, closes #1388 #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can configure any S3 option listed in https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#constructor-property. It adds a warning about the official S3 names `accessKeyId` and `secretAccessKey` because you should use the Companion-style names `key` and `secret` instead.
|
@ifedapoolarewaju finally added your awsClientOptions suggestion above! |
ifedapoolarewaju
approved these changes
Mar 4, 2020
goto-bus-stop
added a commit
that referenced
this pull request
Mar 9, 2020
Accidentally removed in #2030. This can cause S3 to reject uploads.
goto-bus-stop
added a commit
that referenced
this pull request
Mar 9, 2020
Accidentally removed in #2030. This can cause S3 to reject uploads.
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
…ansloadit#2030) * companion: allow providing any S3 option, closes transloadit#1388 Now you can configure any S3 option listed in https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#constructor-property. It adds a warning about the official S3 names `accessKeyId` and `secretAccessKey` because you should use the Companion-style names `key` and `secret` instead. * companion: use awsClientOptions property for Aws SDK config * companion: also reject keys inside awsClientOptions * should keep the checks next to each other * companion: first check if awsClientOptions isnt null
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
…loadit#2113) Accidentally removed in transloadit#2030. This can cause S3 to reject uploads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can configure any S3 option listed in
https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#constructor-property.
It adds a warning about the official S3 names
accessKeyIdandsecretAccessKeybecause you should use the Companion-style nameskeyand
secretinstead.