Bucket endpoint path for S3

[mkuziemko]

Hello!

When I set custom S3 endpoint for companion server:
endpoint: 'http://127:0.0.1

It is translate to endpoint:
endpoint: 'http://{bucket}.127:0.0.1

It is possible to add configurable bucket endpoint, like:
endpoint: 'http://127:0.0.1/{bucket}

Thanks for your help.

[goto-bus-stop]

We pass the endpoint string directly to the AWS SDK's endpoint option. Right now we don't pass through any other options basically.

https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#constructor-property

I think the SDK's way of doing this would be using the s3BucketEndpoint: true option so you could do

endpoint: 'http://127.0.0.1/bucketname',
s3BucketEndpoint: true

So we should maybe spread unknown properties from providerOptions.s3 into the S3 client options here

uppy/packages/@uppy/companion/src/uppy.js

Lines 202 to 207 in a0654c2

	s3Client = new S3({
	region: config.region,
	endpoint: config.endpoint,
	credentials,
	signatureVersion: 'v4'
	})

[kvz]

Hi there, we discussed this with the team and we agree it would be a good idea to allow the s3 options to be configurable. We're going to allow ~all options to be overridden. We don't have an ETA for this yet though, and if someone in the community feels like contributing a PR we would be very grateful!