Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove locales for now #1355

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Remove locales for now #1355

merged 2 commits into from
Mar 19, 2019

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Mar 18, 2019

Fixes #1348

Locales have been outdated for some time, while we were planning on updating everything. The docs for each plugin https://uppy.io/docs/drag-drop/#locale and source code are the source of truth right now.

The reason the folder is around, is we thought we’ll use some of the old strings to help translate the news ones. Can do that using history, so removing to avoid confusion.

Fixes #1348

Locales have been outdated for some time, while we were planning on updating everything. The docs for each plugin https://uppy.io/docs/drag-drop/#locale and source code are the source of truth right now.

The reason the folder is around, is we thought we’ll use some of the old strings to help translate the news ones. Can do that using history, so removing to avoid confusion.
Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uppy/utils/Translator tests use these locale files, so some keys need to be inlined there probably (that's better for test isolation anyway)

@arturi
Copy link
Contributor Author

arturi commented Mar 18, 2019

Thanks for the note! And how wonderful it is when test actually tell us when something is broken 😂

@arturi arturi merged commit 7bc2748 into master Mar 19, 2019
@arturi arturi deleted the chore/remove-old-locales branch March 19, 2019 17:45
@paskuale75
Copy link

please update the documentation then, I was going crazy trying to load the package "npm-asset / uppy--locales".

@goto-bus-stop
Copy link
Contributor

@paskuale75 What documentation are you referring to? Locales have been in the @uppy/locales since our 1.0 release. This PR removed the locales from the old locale system which has been replaced.

@paskuale75
Copy link

I've a composer require "npm-asset/uppy": "^1.21" and there is no trace of the /locales folder

@paskuale75
Copy link

paskuale75 commented Sep 19, 2020

I started writing a wrapper for the Yii2 framework here and I was trying to make the language dynamic, from this documentation's page

@goto-bus-stop
Copy link
Contributor

@uppy/locales is a separate npm package. (the @ indicates a scoped package.) You need to install it separately.

@paskuale75
Copy link

yes and I found it here it's right ? OMG up to an hour ago composer returned this error to me:
Could not find a matching version of package npm-asset/uppy--locales. Check the package spelling, your version constraint and that
the package is available in a stability which matches your minimum-stability (stable).

but now he took it. Thanks for all the answers and for this great upload plugin ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please deprecate the "locales" folder
3 participants