-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove locales for now #1355
Remove locales for now #1355
Conversation
Fixes #1348 Locales have been outdated for some time, while we were planning on updating everything. The docs for each plugin https://uppy.io/docs/drag-drop/#locale and source code are the source of truth right now. The reason the folder is around, is we thought we’ll use some of the old strings to help translate the news ones. Can do that using history, so removing to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uppy/utils/Translator
tests use these locale files, so some keys need to be inlined there probably (that's better for test isolation anyway)
Thanks for the note! And how wonderful it is when test actually tell us when something is broken 😂 |
please update the documentation then, I was going crazy trying to load the package "npm-asset / uppy--locales". |
@paskuale75 What documentation are you referring to? Locales have been in the |
I've a composer require "npm-asset/uppy": "^1.21" and there is no trace of the /locales folder |
|
yes and I found it here it's right ? OMG up to an hour ago composer returned this error to me: |
Fixes #1348
Locales have been outdated for some time, while we were planning on updating everything. The docs for each plugin https://uppy.io/docs/drag-drop/#locale and source code are the source of truth right now.
The reason the folder is around, is we thought we’ll use some of the old strings to help translate the news ones. Can do that using history, so removing to avoid confusion.