Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please deprecate the "locales" folder #1348

Closed
vito80ba opened this issue Mar 13, 2019 · 1 comment · Fixed by #1355
Closed

Please deprecate the "locales" folder #1348

vito80ba opened this issue Mar 13, 2019 · 1 comment · Fixed by #1355
Labels
🌏 Locale Translations and internationalization

Comments

@vito80ba
Copy link

Hi,
I've tried to use the language files in the "Locales" folder located in this github repo... after some minutes of panic I've discovered that the map of the strings doesn't match with the js file.

So, I suppose that the structure of the language files are not useful... maybe is'nt better to drop the "locales" folder?

Vito

@arturi
Copy link
Contributor

arturi commented Mar 14, 2019

Hi! Sorry about that. Locales have been outdated for some time, while we were planning on updating everything. The docs for each plugin https://uppy.io/docs/drag-drop/#locale and source code are the source of truth right now.

The reason the folder is around, is I thought we’ll use some of the old strings to help translate the news ones.

@arturi arturi added the 🌏 Locale Translations and internationalization label Mar 14, 2019
arturi added a commit that referenced this issue Mar 18, 2019
Fixes #1348

Locales have been outdated for some time, while we were planning on updating everything. The docs for each plugin https://uppy.io/docs/drag-drop/#locale and source code are the source of truth right now.

The reason the folder is around, is we thought we’ll use some of the old strings to help translate the news ones. Can do that using history, so removing to avoid confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌏 Locale Translations and internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants